Add support for setting ICE ufrag and pwd #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding fields to the config struct breaks compatibility and would mean releasing a new major version of libjuice. You should instead introduce a function |
|
shure. |
paullouisageneau
approved these changes
May 14, 2024
paullouisageneau
changed the title
This was referenced Jun 5, 2024
achingbrain
added a commit
to achingbrain/node-datachannel
that referenced
this pull request
Jun 6, 2024
paullouisageneau/libjuice#243 allows setting the ICE ufrag and pwd fields instead of generating random ones every time. paullouisageneau/libdatachannel#1201 exposes config keys to allow setting the fields in libjuice from libdatachannel. This PR allows setting the fields in libdatachannel from the PeerConnection constructor. It will require the two PRs above being merged an shipped before this is ready for merging. Refs: paullouisageneau/libdatachannel#1166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support Peer A and Peer B in WebRTC Direct, we need to be able to specify the ufrag and pwd of the localDescription. WebRTC Direct's documentation suggests replacing the ufrag and pwd with setLocalDescription. This is not compliant with the standard.
Therefore, I propose another solution, we can set ufrag and pwd in juice_create, which can satisfy both Peer A and Peer B's needs, and will not modify the existing logic in any way.