Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tc version check #29

Merged
merged 25 commits into from
Jul 2, 2024
Merged

Tc version check #29

merged 25 commits into from
Jul 2, 2024

Conversation

rruiter87
Copy link
Contributor

@rruiter87 rruiter87 commented Jun 24, 2024 •
edited
Loading

Added the proposed hook as discussed in #28

When run on the current TcOpen repo I get this

Not all files have the same TwinCAT version:
 -src/IntegrationProjects/src/XAE/XAE/XAEIntegrationProjects.tsproj: 3.1.4024.22
 -src/Tc.Prober/tests/TcProber/TcProber.tsproj: 3.1.4024.22
 -src/TcOpen.Hammer/TcOpenHammer/TcOpenHammer/TcOpenHammer.tsproj: 3.1.4024.25
 -src/TcoAbbRobotics/src/XaeTcoAbbRobotics/XaeTcoAbbRobotics.tsproj: 3.1.4024.44
 -src/TcoAbstractions/src/XAE/XAE/XAETcoAbstractions.tsproj: 3.1.4024.32
 -src/TcoAimTtiPowerSupply/src/XaeTcoAimTtiPowerSupply/XaeTcoAimTtiPowerSupply.tsproj: 3.1.4024.44
 -src/TcoApplicationExamples/XaeAppExamples/XaeAppExamples.tsproj: 3.1.4024.22
 -src/TcoCognexVision/src/XAE/XAE/XAETcoCognexVision.tsproj: 3.1.4024.55
 -src/TcoCore/src/XaeTcoCore/XaeTcoCore.tsproj: 3.1.4024.55
 -src/TcoData/src/XAE/XAE/XAETcoData.tsproj: 3.1.4024.55
 -src/TcoDrivesBeckhoff/src/XaeTcoDrivesBeckhoff/XaeTcoDrivesBeckhoff.tsproj: 3.1.4024.55
 -src/TcoElements/src/XAE/XAE/XAETcoElements.tsproj: 3.1.4024.44
 -src/TcoInspectors/src/XAE/XAE/XAETcoInspectors.tsproj: 3.1.4024.55
 -src/TcoIo/src/XAE/XAE/XAETcoIo.tsproj: 3.1.4024.32
 -src/TcoKukaRobotics/src/XaeTcoKukaRobotics/XaeTcoKukaRobotics.tsproj: 3.1.4024.44
 -src/TcoMitsubishiRobotics/src/XaeTcoMitsubishiRobotics/XaeTcoMitsubishiRobotics.tsproj: 3.1.4024.44
 -src/TcoPneumatics/src/XaeTcoPneumatics/XaeTcoPneumatics.tsproj: 3.1.4024.44
 -src/TcoRexrothPress/src/XAE/XAE/XAETcoRexrothPress.tsproj: 3.1.4024.32
 -src/TcoTixonFeeding/src/XaeTcoTixonFeeding/XaeTcoTixonFeeding.tsproj: 3.1.4024.55
 -src/TcoUrRobotics/src/XaeTcoUrRobotics/XaeTcoUrRobotics.tsproj: 3.1.4024.44
 -src/TcoUtilities/src/XAE/XAE/XAETcoUtilities.tsproj: 3.1.4024.44
 -src/librarytemplate/src/XAE/XAE/XAEPlcTemplate.tsproj: 3.1.4024.32

ZLLentz
ZLLentz reviewed Jun 24, 2024
View reviewed changes
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few small things, looks good overall!

pre_commit_hooks/check_twincat_versions.py Outdated Show resolved Hide resolved
pre_commit_hooks/check_twincat_versions.py Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pre_commit_hooks/check_twincat_versions.py Outdated Show resolved Hide resolved
pre_commit_hooks/exceptions.py Show resolved Hide resolved
pre_commit_hooks/tests/test_check_twincat_versions.py Outdated Show resolved Hide resolved
@ZLLentz ZLLentz mentioned this pull request Jun 24, 2024
Merged
@rruiter87
Copy link
Contributor Author

Thanks for the detailed review!

ZLLentz
ZLLentz previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the readme edit this is definitely mergeable, I'll let you decide how much further you want to go prior to merge.

@rruiter87 rruiter87 requested a review from ZLLentz July 1, 2024 08:19
ZLLentz
ZLLentz reviewed Jul 1, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@rruiter87 rruiter87 requested a review from ZLLentz July 2, 2024 07:36
ZLLentz
ZLLentz approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything has been addressed, thank you for your efforts!
I'm going to merge this and tag the repository at v1.7.0

@ZLLentz ZLLentz merged commit eecdf9a into pcdshub:master Jul 2, 2024
@ZLLentz ZLLentz mentioned this pull request Jul 2, 2024
Closed
@rruiter87
Copy link
Contributor Author

Awesome. And thank you for the extensive review. 👍

@rruiter87 rruiter87 deleted the tc-version-check branch July 3, 2024 08:18
@ZLLentz ZLLentz mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZLLentz ZLLentz ZLLentz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rruiter87 @ZLLentz