Add and run ruff on all files #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZLLentz
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
I was aware of ruff as a better version of flake8 but I was not aware that it also supplanted black and isort. I haven't made an effort to switch to ruff in my other projects yet but maybe now I will.
I trust ruff/black but I reviewed the diff closely just to make sure.
Do you want this merged before or after #29 ?
|
Before would be good. Then I can run ruff on the other PR before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started using ruff for my Python projects some time ago and I really like it. I automatically runs Python's formatter Black, isort and can automatically fix a whole host of flake-8 issues.
Currently it is annoying to develop new pre-commits, because of all the flake-8 violations. With this tool it takes care of most of it.
The disadvantage is that you have to run it once and it makes a lot of changes. Although these can be ignored as explained here.