K8SPXC-885: Fix validation webhook on k8s 1.22 #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation webhook was failing with `json: unknown field "subresource"` on decoding the admission request. It's because of the new "subresource" field in `metadata.managedFields`[^0]. Folks in Knative fixed the issue[^1] with creating a custom json decoder that ignores unknown fields *only* in metadata. [^0]: kubernetes/apimachinery@5c420e5 [^1]: knative/pkg#2249
delgod
suggested changes
Oct 16, 2021
Co-authored-by: Mykola Marzhan <[email protected]>
delgod
approved these changes
Oct 18, 2021
hors
approved these changes
Oct 18, 2021
defbin
approved these changes
Oct 18, 2021
commit: c76e2f1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation webhook was failing with
json: unknown field "subresource"on decoding the admission request. It's because of the new "subresource"
field in
metadata.managedFields1. Folks in Knative fixed theissue2 with creating a custom json decoder that ignores unknown
fields only in metadata.
Footnotes
https://github.com/kubernetes/apimachinery/commit/5c420e58bf9057fbc9457744dceaa765ef78c9dd ↩
https://github.com/knative/pkg/pull/2249 ↩