Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8SPXC-885: Fix validation webhook on k8s 1.22 #1021

Merged
merged 2 commits into from
Oct 18, 2021
Merged

K8SPXC-885: Fix validation webhook on k8s 1.22 #1021

merged 2 commits into from
Oct 18, 2021

Commits on Oct 15, 2021

  1. K8SPXC-885: Fix validation webhook on k8s 1.22 

    Validation webhook was failing with `json: unknown field "subresource"`
on decoding the admission request. It's because of the new "subresource"
field in `metadata.managedFields`[^0]. Folks in Knative fixed the
issue[^1] with creating a custom json decoder that ignores unknown
fields *only* in metadata.

[^0]: kubernetes/apimachinery@5c420e5
[^1]: knative/pkg#2249
    @egegunes
    egegunes committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    4368519 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2021

  1. address review comments 

    Co-authored-by: Mykola Marzhan <[email protected]>
    @egegunes @delgod
    egegunes and delgod committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    c76e2f1 View commit details
    Browse the repository at this point in the history