Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC-2023] Modifying - withpointsdd #2544

Merged
merged 7 commits into from
Aug 20, 2023

Conversation

squarege
Copy link
Contributor

@squarege squarege commented Aug 19, 2023

This PR modifies one existing function:

  • pgr_withPointsDD:
    • Improving the 'driver_side' optional parameter to compulsory parameter.
    • Adding one new result column 'depth'.
    • Normalizing the output.

This is a final merge PR containing commits from several different PRs combined.

The intermediate PRs made on the GSoC-pgRouting repository are as follows:

Description Pull Requests
pgr_withPointsDD

The wiki page with more details on this project can be found here.

* [drivers][driving_distance] driver added capability of including
new result column
  * changed structure: Path_rt -> MST_rt
  * simplified code, removed parameter names
* [driving_distance] new file: withPointsDD.hpp
  * created a new class to calculate depth
  * used pgrouting::functions namespace
* Handling old & new code
* Removing unnecesary comments
* [C++] Calling function to get new results column
* [C] Creating internal function _pgr_v4withpointsdd for new signature
* [C] Changing the evaluation on the driving side
  * if graph is directed then valid values are [R, L, r, l],
  * else valid values are [B, b]
* Changing driving side from optional to compulsory param
* Including start_vid and depth in the output of single vertex overload
* Including depth in the output of multiple vertices overload
* Updating v3.6 signature file
* Passing update test
* [pgr_withPointsDD] Updating for new signature and new outputs
* [migration] Updating migration guidance for pgr_withPointsDD
* [pgRouting-introduction] Adding name into developer list
@squarege squarege self-assigned this Aug 19, 2023
@cvvergara
Copy link
Member

Codacy errors are ignored

Copy link
Member

@krashish8 krashish8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thanks for all the efforts 🎉 @squarege

@krashish8 krashish8 added the GSoC label Aug 19, 2023
Copy link
Member

@robe2 robe2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@shobhit162 shobhit162 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks @squarege for your contributions!

@squarege squarege merged commit 1f009e8 into pgRouting:develop Aug 20, 2023
13 checks passed
@cvvergara cvvergara added this to the Release 3.6.0 milestone Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants