-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC-2023] Modifying - withpointsdd #2544
Conversation
* [drivers][driving_distance] driver added capability of including new result column * changed structure: Path_rt -> MST_rt * simplified code, removed parameter names * [driving_distance] new file: withPointsDD.hpp * created a new class to calculate depth * used pgrouting::functions namespace
…instead of b as the default value
* Handling old & new code * Removing unnecesary comments * [C++] Calling function to get new results column * [C] Creating internal function _pgr_v4withpointsdd for new signature * [C] Changing the evaluation on the driving side * if graph is directed then valid values are [R, L, r, l], * else valid values are [B, b]
* Changing driving side from optional to compulsory param * Including start_vid and depth in the output of single vertex overload * Including depth in the output of multiple vertices overload * Updating v3.6 signature file * Passing update test
* [pgr_withPointsDD] Updating for new signature and new outputs * [migration] Updating migration guidance for pgr_withPointsDD * [pgRouting-introduction] Adding name into developer list
Codacy errors are ignored |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks for all the efforts 🎉 @squarege
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks @squarege for your contributions!
This PR modifies one existing function:
pgr_withPointsDD
:This is a final merge PR containing commits from several different PRs combined.
The intermediate PRs made on the GSoC-pgRouting repository are as follows:
The wiki page with more details on this project can be found here.