Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Added Phalcon\Validation for Phalcon\Mvc\Collection #12445

Merged
merged 1 commit into from
Jan 12, 2017
Merged

[WIP] Added Phalcon\Validation for Phalcon\Mvc\Collection #12445

merged 1 commit into from
Jan 12, 2017

Conversation

Jurigag
Copy link
Contributor

@Jurigag Jurigag commented Nov 30, 2016 •
edited
Loading

Hello!

  • Type: new feature

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.
  • Extensive Uniqueness tests

Small description of change: This add option to use Phalcon\Validation for Phalcon\Mvc\Collection while keeping BC for old syntax. Refs #12376

Thanks

@Jurigag Jurigag changed the title Added Phalcon\Validation for Phalcon\Mvc\Collection [WIP]Added Phalcon\Validation for Phalcon\Mvc\Collection Nov 30, 2016
@Jurigag Jurigag closed this Dec 3, 2016
@Jurigag Jurigag reopened this Dec 3, 2016
@sergeyklay sergeyklay added this to the 3.1.0 milestone Dec 3, 2016
@sergeyklay sergeyklay added the new feature request Planned Feature or New Feature Request label Dec 3, 2016
@Jurigag Jurigag force-pushed the 3.1.x-collection-validation branch 5 times, most recently from a945748 to 5549828 Compare December 4, 2016 11:33
@Jurigag
Copy link
Contributor Author

Jurigag commented Dec 4, 2016

Is there any mongo expert ? Can you check if uniqueness validator logic is correct ?

@Jurigag Jurigag force-pushed the 3.1.x-collection-validation branch 16 times, most recently from b97024b to a9de074 Compare December 4, 2016 18:43
@Jurigag Jurigag force-pushed the 3.1.x-collection-validation branch 5 times, most recently from dc1a711 to 9b87d17 Compare December 21, 2016 12:56
@Jurigag Jurigag force-pushed the 3.1.x-collection-validation branch 17 times, most recently from e0ead92 to 8bf6b84 Compare January 12, 2017 12:51
@Jurigag Jurigag closed this Jan 12, 2017
@Jurigag Jurigag reopened this Jan 12, 2017
@Jurigag
Copy link
Contributor Author

Jurigag commented Jan 12, 2017 •
edited
Loading

This is ready to merge i think. After being merged i will try to handle this phalcon/incubator#700

@sergeyklay sergeyklay merged commit 90023b1 into phalcon:3.1.x Jan 12, 2017
@sergeyklay
Copy link
Contributor

Thanks

@Jurigag Jurigag deleted the 3.1.x-collection-validation branch January 13, 2017 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virgofx virgofx virgofx left review comments

@sergeyklay sergeyklay sergeyklay requested changes

Assignees

@sergeyklay sergeyklay

@Jurigag Jurigag

Labels
new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Jurigag @sergeyklay @virgofx