You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In phalcon 3.1.0 there will be added Phalcon\Validation support for Phalcon\Mvc\Collectionphalcon/cphalcon#12445. Since that MongoCollection need some changes to make it work with Phalcon\Validation too as well with Uniqueness validator(DIRTY states).
~Any idea how to solve it ? Should there be whole different Uniqueness class for MongoCollection in incubator ? Or i will just add proper PR with class_exists(in uniqueness validator) and instanceof check after someone will make MongoCollection working with validation and Uniqueness validator ?~~~
Well MongoCollection extends Phalcon collection so whatever.
Also if someone know Mongo well enough and is using it could check Uniqueness source if it's correct in this PR to work with Mongo correctly. I guess will add tests to check all cases anyway.
The text was updated successfully, but these errors were encountered:
Jurigag
changed the title
[NFR]MongoCollection Uniqueness support
[NFR]MongoCollection Uniqueness and Phalcon\Validation support
Dec 4, 2016
In phalcon 3.1.0 there will be added
Phalcon\Validation
support forPhalcon\Mvc\Collection
phalcon/cphalcon#12445. Since that MongoCollection need some changes to make it work withPhalcon\Validation
too as well with Uniqueness validator(DIRTY states).~Any idea how to solve it ? Should there be whole different Uniqueness class for MongoCollection in incubator ? Or i will just add proper PR with class_exists(in uniqueness validator) and instanceof check after someone will make MongoCollection working with validation and Uniqueness validator ?~~~
Well MongoCollection extends Phalcon collection so whatever.
Also if someone know Mongo well enough and is using it could check Uniqueness source if it's correct in this PR to work with Mongo correctly. I guess will add tests to check all cases anyway.
The text was updated successfully, but these errors were encountered: