Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR]MongoCollection Uniqueness and Phalcon\Validation support #700

Closed
Jurigag opened this issue Dec 4, 2016 · 2 comments
Closed

[NFR]MongoCollection Uniqueness and Phalcon\Validation support #700

Jurigag opened this issue Dec 4, 2016 · 2 comments
Assignees
Labels

Comments

@Jurigag
Copy link
Contributor

Jurigag commented Dec 4, 2016

In phalcon 3.1.0 there will be added Phalcon\Validation support for Phalcon\Mvc\Collection phalcon/cphalcon#12445. Since that MongoCollection need some changes to make it work with Phalcon\Validation too as well with Uniqueness validator(DIRTY states).

~Any idea how to solve it ? Should there be whole different Uniqueness class for MongoCollection in incubator ? Or i will just add proper PR with class_exists(in uniqueness validator) and instanceof check after someone will make MongoCollection working with validation and Uniqueness validator ?~~~

Well MongoCollection extends Phalcon collection so whatever.

Also if someone know Mongo well enough and is using it could check Uniqueness source if it's correct in this PR to work with Mongo correctly. I guess will add tests to check all cases anyway.

@Jurigag Jurigag changed the title [NFR]MongoCollection Uniqueness support [NFR]MongoCollection Uniqueness and Phalcon\Validation support Dec 4, 2016
@Jurigag
Copy link
Contributor Author

Jurigag commented Mar 8, 2017

Before we release phalcon 3.1.0 i think this should be implemented i think @sergeyklay

@Jurigag
Copy link
Contributor Author

Jurigag commented Mar 15, 2017

Implemented in 3.1.x branch

@Jurigag Jurigag closed this as completed Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants