Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T15844 sha1 #15845

Closed
wants to merge 11 commits into from
Closed

T15844 sha1 #15845

wants to merge 11 commits into from

Conversation

niden
Copy link
Member

@niden niden commented Dec 28, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Removed references to sha1 in favor of hash("sha256", $data) to ensure that there are never any collisions.

Thanks

@niden niden requested a review from Jeckerson December 28, 2021 17:02
@niden niden self-assigned this Dec 28, 2021
@niden niden added 5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low labels Dec 28, 2021
@niden niden linked an issue Dec 28, 2021 that may be closed by this pull request
@niden niden closed this Dec 28, 2021
@niden niden deleted the T15844-sha1 branch December 28, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Convert sha1 references to hash
2 participants