Add MongoCollection Uniqueness compatibility #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyklay
suggested changes
Mar 9, 2017
tests/_data/collections/Robots.php
Outdated
| * User: User | ||
| * Date: 2017-03-09 | ||
| * Time: 17:11 | ||
| */ |
There was a problem hiding this comment.
Could you please remove this
| * @copyright (c) 2011-2017 Phalcon Team | ||
| * @link https://www.phalconphp.com | ||
| * @author Wojciech Ślawski <[email protected]> | ||
| * @package Phalcon\Test\Mvc |
There was a problem hiding this comment.
Phalcon\Test\Mvc\Collection
Jurigag
force-pushed
the
3.1.x-mongo-collection
branch
from
67ce1f7
to
589795a
Compare
|
I have no idea why tests are failing.
Any idea what this mean? |
sergeyklay
suggested changes
Mar 9, 2017
tests/_data/collections/Users.php
Outdated
| * User: User | ||
| * Date: 2017-03-09 | ||
| * Time: 17:07 | ||
| */ |
There was a problem hiding this comment.
Could you please remove this
| * User: User | ||
| * Date: 2017-03-09 | ||
| * Time: 17:06 | ||
| */ |
There was a problem hiding this comment.
Could you please remove this
Jurigag
force-pushed
the
3.1.x-mongo-collection
branch
6 times, most recently
from
7aee6fc
to
69a7fe0
Compare
Jurigag
force-pushed
the
3.1.x-mongo-collection
branch
6 times, most recently
from
e9a9eef
to
ee121b9
Compare
Jurigag
force-pushed
the
3.1.x-mongo-collection
branch
from
ee121b9
to
65d8907
Compare
sergeyklay
approved these changes
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This pull request affects the following components: (please check boxes)
In raising this pull request, I confirm the following (please check boxes):
Small description of change: this is adding compability for MongoCollection to work with
Phalcon\Validation\Validator\Uniquenesssince from phalcon 3.1.x Collection can usePhalcon\Validationcomponent.Thanks