Merge pull request #632 from pharo-graphics/CleanupEventDispatching

Clean ups in events, space and universe

src/Bloc-DevTool/BlBenchmarkConsole.class.st

@@ -77,7 +77,7 @@ BlBenchmarkConsole >> listenSpace: aSpace [
 	lastTime := aSpace time now.
 	frames := 0.
 	framesLimit := 120.
-	aSpace eventDispatcher addEventHandler: 
+	aSpace addEventHandler: 
 		(BlEventHandler on: BlSpaceRenderEndEvent do: [ :evt | 
 				frames := frames + 1.
 				frames % framesLimit = 0
@@ -86,11 +86,11 @@ BlBenchmarkConsole >> listenSpace: aSpace [
 						lastTime := evt end.
 						frames := 0 ].
 				self renderTime: (evt end - evt start) ]).
-	aSpace eventDispatcher addEventHandler: 
+	aSpace addEventHandler: 
 		(BlEventHandler on: BlSpaceEventsProcessedEvent do: [ :evt | 
 					self eventProcessingTime: (evt end - evt start). 
 					  ]).
-  	aSpace eventDispatcher addEventHandler: 
+  	aSpace addEventHandler: 
 		(BlEventHandler on: BlSpaceLayoutEndEvent do: [ :evt | 
 					self layoutTime: (evt end - evt start). 
 					  ])

src/Bloc-Tests/BlHostPulseLoopTest.class.st

@@ -27,7 +27,7 @@ BlHostPulseLoopTest >> testOpeningAnSpaceDeferingAnErrorKeepsLoopRunning [
 	aSpace show.
 
 	logger := MemoryLogger new.
-	logger runFor: BlParallelUniverseErrorDuringPulse during: [	
+	logger runFor: BlParallelUniverseErrorDuringPulseSignal during: [	
 			aSpace universe defer: [ 1 error: 'I am the debugger to kill' ].	
 			[aSpace universe hasDeferredActions] whileTrue: [ 
 				100 milliSeconds wait

src/Bloc-Tests/BlSpaceEventTest.class.st

@@ -40,29 +40,6 @@ BlSpaceEventTest >> testSpaceClosed [
 	self assert: count equals: 1
 ]
 
-{ #category : #tests }
-BlSpaceEventTest >> testSpaceDestroyed [
-
-	| events |
-	events := OrderedCollection new.
-
-	space
-		addEventHandlerOn: BlSpaceClosedEvent
-		do: [ events add: #closed ].
-	space
-		addEventHandlerOn: BlSpaceDestroyedEvent
-		do: [ events add: #destroyed ].
-
-	space show.
-	self waitPulses.
-	self assert: events size equals: 0.
-
-	space close.
-	self waitPulses.
-	self assert: events size equals: 2.
-	self assert: events asArray equals: #( closed destroyed )
-]
-
 { #category : #tests }
 BlSpaceEventTest >> testSpaceShown [
 

src/Bloc/BlElement.class.st

@@ -3933,16 +3933,15 @@ BlElement >> whenLayoutedDo: aBlock [
 
 { #category : #'geometry hooks' }
 BlElement >> whenLayoutedDoOnce: aBlock [
-	"As an example of use, imagine you need to get the actual size of an element.
+	"Evaluate block passed as argument after the layout applied.
+
+	As an example of use, imagine you need to get the actual size of an element.
 	The size is computed by the layout.
-	Thus, if one need to get the size of an element one have to be sure that its layout applied.
-	This is the purpose of #whenLayoutedDoOne: (when layout applied do once) which intention is to run
-	the block passed as argument only one time just after the layout applied.
-		
-	** notice ** that my use is not encouraged except for debugging or for particular purposes 
-	ouside usual Bloc coding
-	"
-	self when: BlElementLayoutComputedEvent doOnce: [ :event | aBlock cull: event ].
+	Thus, if one need to get the size of an element one have to be sure that its layout applied."
+
+	^ self
+		addEventHandlerOn: BlElementLayoutComputedEvent
+		doOnce: aBlock
 ]
 
 { #category : #'api - bounds' }

src/Bloc/BlHeadlessHostSpace.class.st

@@ -102,6 +102,12 @@ BlHeadlessHostSpace >> isResizable [
 	^ true
 ]
 
+{ #category : #testing }
+BlHeadlessHostSpace >> isValid [
+
+	^ true
+]
+
 { #category : #'host space - testing' }
 BlHeadlessHostSpace >> isVisible [
 	"Return true if underlying window is shown, false otherwise.

src/Bloc/BlHost.class.st

@@ -13,6 +13,12 @@ Class {
 	#category : #'Bloc-Universe - Host'
 }
 
+{ #category : #testing }
+BlHost class >> hasUniverse [
+
+	^ BlParallelUniverse existsForHost: self
+]
+
 { #category : #'api - lifecycle' }
 BlHost class >> isRunning [
 	^ self subclassResponsibility

src/Bloc/BlHostPulseLoop.class.st

@@ -116,13 +116,13 @@ BlHostPulseLoop >> loopIteration [
 
 	[
 		pulseStartMS := Time millisecondClockValue.
-		universe := BlParallelUniverse forHost: hostClass.
+		universe := hostClass universe.
 		universe pulse.
 		pulseDurationMS := Time millisecondClockValue - pulseStartMS.
 		self waitUntilNextPulse. ]
 	on: Exception
 	do: [ :e |
-			self forceStartNewUIProcess.
+		self forceStartNewUIProcess.
 		e pass ].
 
 	"Returns true to continue looping"