Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean ups in events, space and universe #632

Merged
merged 29 commits into from
Oct 24, 2024
Merged

Clean ups in events, space and universe #632

merged 29 commits into from
Oct 24, 2024

Conversation

tinchodias
Copy link
Collaborator

No description provided.

@tinchodias
Copy link
Collaborator Author

I'm sorry, the commit 0b3a1c6 is empty because I clicked twice in the Iceberg button...

@tinchodias tinchodias mentioned this pull request Oct 21, 2024
Closed
@tinchodias
BlParallelUniverse was missing hasPostponedActions
2091afb
@tinchodias
BlHeadlessHostSpace was missing isValid, as other host spaces have
ab142b1
@tinchodias
Send #universe instead of referencing BlParallelUniverse
3ecdb2d 
Fixes #635
@tinchodias
Deprecate event target's #when:doOnce: in favor of #addEventHandlerOn…
03a977d 
…:doOnce:

See #631
@tinchodias
BlSpace: Deprecate pulseRequested in favor of isPulseRequested
b132c14
@tinchodias
Fix parent commit
1d55111
@tinchodias
Remove BlSpaceDestroyedEvent
01a9b26 
See: #641
@tinchodias
BlMorphicSteppingHost: Send #universe instead of referencing BlParall…
9723747 
…elUniverse

Fixes #635
@tinchodias
Cleanup and reformat some methods in BlSpaceManager and BlParallelUni…
a15905a 
…verse
@tinchodias
BlParallelUniverse close and detach: remove double check for isOpened…
697b476 
… (keep the deferred check)
@tinchodias
Revert "BlParallelUniverse close and detach: remove double check for …
06630c6 
…isOpened (keep the deferred check)"

This reverts commit 697b476.
@tinchodias
Only reformat and fix comments of closeSpace: and detachSpace:
ab1aa33
@tinchodias
Make closeSpaceSynchronously: delegate on detachSpaceSynchronously:
e2550e8 
See #636
@tinchodias
Make openSpaceSynchronously: delegate on attachSpaceSynchronously:
47df523 
See: #636
@tinchodias
Support siwtching host of an opened space
0a80636 
Fixes #636
@tinchodias
Delete almost all BeaconSignals
fb1a3f9 
See #624
@tinchodias
Remove id from BlSpace, BlTask and BlParallelUniverse
fc73324 
Also, remove BlUniqueIdGenerator as it is unreferenced now.

Fixes #639
@tinchodias
Merge BlSpaceManager into BlParallelUniverse
29aac9a 
This change requires the evaluation of "BlParallelUniverse initialize" avoid breaking any active universe.

Fixes #637
@tinchodias
Remove 2 BlSpace methods in protocol 'NOT-USED-private-change'
ab62c1a 
Fixes #640
@tinchodias
Copy link
Collaborator Author

tinchodias commented Oct 24, 2024 •
edited
Loading

Issues closed by this PR:

@tinchodias tinchodias changed the title Cleanup event dispatching Clean ups in events, space and universe Oct 24, 2024
@tinchodias tinchodias merged commit 0d23168 into dev Oct 24, 2024
12 checks passed
@tinchodias tinchodias deleted the CleanupEventDispatching branch October 24, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tinchodias