Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is the state of States? #423

Closed
jecisc opened this issue Jan 26, 2024 · 0 comments · Fixed by #424
Closed

What is the state of States? #423

jecisc opened this issue Jan 26, 2024 · 0 comments · Fixed by #424

Comments

@jecisc
Copy link
Member

jecisc commented Jan 26, 2024

I found in Bloc the concept of States. A BlElement has a #states method and this is used by a lot of subclasses of BlElementStateEventHandler.

But if we check BlElement>>#states we see that it returns nil. So my question is: Is this feature still supported? Is it broken but we plan to bring it back? Should we remove the states?
jecisc added a commit to jecisc/Bloc that referenced this issue Jan 26, 2024
@jecisc
Remove Bloc-States
0a2314b 
After a discussion with Martin it seems that states are now unused un Bloc and are now in Toplo with a better implementation. So I propose to remove them.

I moved the code in https://github.com/pharo-graphics/Bloc-LegacyCode

Note that this PR depends on pharo-graphics#422 because it would have created conflicts otherwise.

Fixes pharo-graphics#423
@jecisc jecisc mentioned this issue Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Bloc-States jecisc/Bloc
1 participant
@jecisc