Remove properties #422
Merged
Remove properties #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes all the code related to properties and some code that was still about styles. I think I found most of the code but feel free to indicated me if I missed some Almost all the code can be found here: https://github.com/pharo-graphics/Bloc-LegacyCode BUT some code just got removed from core bloc methods soe loading this package will not just bring back all the behavior.
jecisc
added a commit
to jecisc/Bloc
that referenced
this pull request
Jan 26, 2024
After a discussion with Martin it seems that states are now unused un Bloc and are now in Toplo with a better implementation. So I propose to remove them. I moved the code in https://github.com/pharo-graphics/Bloc-LegacyCode Note that this PR depends on pharo-graphics#422 because it would have created conflicts otherwise. Fixes pharo-graphics#423
Merged
tinchodias
approved these changes
Jan 26, 2024
|
BlElement>>theme: aTheme |
|
@plantec what do you think of removing the whole package? |
tinchodias
added a commit
that referenced
this pull request
Jan 30, 2024
In fact they can't be loaded now, since BlElementProperty has gone. This complements #422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes all the code related to properties and some code that was still about styles.
I think I found most of the code but feel free to indicated me if I missed some
Almost all the code can be found here: https://github.com/pharo-graphics/Bloc-LegacyCode
BUT some code just got removed from core bloc methods soe loading this package will not just bring back all the behavior.
Fixes #420