Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBlEventTarget: all methods to add event handler and filter handler should answer the new handler #631

Closed
tinchodias opened this issue Oct 18, 2024 · 1 comment

Comments

@tinchodias
Copy link
Collaborator

In #443 we made TBlEventTarget>>#addEventHandlerOn:do: answer the new handler (this way, it is handy for senders to keep a reference to the handler and, for example, be able to remove it afterwards).

But we missed to do the same on other similar selectors in the trait, such as:

  • addEventHandlerIfNotPresent:
  • addEventFilterOn:do:
  • when:doOnce: (but this also needs to be renamed and deprecated)
@tinchodias
Copy link
Collaborator Author

It's done for addEventFilterOn:do:, but it was not necessary for addEventHandlerIfNotPresent: because it already receives an instance of the handler.
It's also done for when:doOnce: but it's deprecated in favor of addEventHandlerOn:doOnce:, that returns the new handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant