Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of Telemetry is inspecting details of the execution of a space.
Why removing it?
Reason 1: it obscures the Bloc code by this kind of permanent instrumentation. For example:
instead of just having
self onLayout: aRectangle context: aBlElementBoundsUpdateContext
. When the telemetry is enabled, the time to run the block is measured, and emitted in a beacon signal to be logged.Reason 2: the telemetry infrastructure involves about 11 classes that contributes to make Bloc harder to comprehend to new users, while general profiling tools and programmer's creativity are enough to get the same conclusions. It may be that stubborn or rustic and I'm missing something important, but I don't find the need for this special tool to profile Bloc.
So, I propose to replace it by this methodology: