-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do we want hosts and universe Beacon signals? #624
Comments
Note: without those signals, the BlParallelUniverse's id becomes not necessary. |
@tinchodias I agree with you. |
yes |
BlParallelUniverse is so much simplified after removing the signal emitting! |
Only one Beacon signal remains: |
In part, I had the idea to remove the signals because they were quite 1:1 with BlSpaceEvent*s. I mean, handling events looked enough to generate a log, and also events are more oriented to react via handlers as a user software. In that sense, BlParallelUniverseErrorDuringPulseSignal may be replaced by a new BlParallelUniversePulseErrorEvent. |
hi @tinchodias, with @Nyan11 we for doing stuff when a space is open with Pyramid (to install a keyboard shortcut to edit it), what event can we used? |
These Beacon signals are only signaled (i.e. only referenced to emit an instance):
They allow a developer to turn on a Beacon logger and watch what happens under the hood.
I create this issue to discuss if either we start to use them to debug, or we remove them and just debug this code as with other projects.
IMHO, this code doesn't help: it makes Bloc a bit harder to comprehend, and just regular Pharo debugging and profiling tools and are enough to debug or understand what happens under the hood.
Reasons would be similar for deleting telemetry months ago: #439
The text was updated successfully, but these errors were encountered: