Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we want hosts and universe Beacon signals? #624

Closed
tinchodias opened this issue Oct 12, 2024 · 8 comments
Closed

Do we want hosts and universe Beacon signals? #624

tinchodias opened this issue Oct 12, 2024 · 8 comments
Labels

Comments

@tinchodias
Copy link
Collaborator

These Beacon signals are only signaled (i.e. only referenced to emit an instance):
Screenshot 2024-10-09 at 16 45 25

They allow a developer to turn on a Beacon logger and watch what happens under the hood.

I create this issue to discuss if either we start to use them to debug, or we remove them and just debug this code as with other projects.

IMHO, this code doesn't help: it makes Bloc a bit harder to comprehend, and just regular Pharo debugging and profiling tools and are enough to debug or understand what happens under the hood.

Reasons would be similar for deleting telemetry months ago: #439

@tinchodias
Copy link
Collaborator Author

Note: without those signals, the BlParallelUniverse's id becomes not necessary.

@tinchodias
Copy link
Collaborator Author

@plantec @labordep do you agree on removing these classes?

@labordep
Copy link
Contributor

@tinchodias I agree with you.

@plantec
Copy link
Collaborator

plantec commented Oct 24, 2024

yes

@plantec plantec closed this as completed Oct 24, 2024
@plantec plantec reopened this Oct 24, 2024
@tinchodias
Copy link
Collaborator Author

BlParallelUniverse is so much simplified after removing the signal emitting!

@tinchodias
Copy link
Collaborator Author

Only one Beacon signal remains: BlParallelUniverseErrorDuringPulseSignal (the Signal suffix was missing and I added it)

@tinchodias
Copy link
Collaborator Author

In part, I had the idea to remove the signals because they were quite 1:1 with BlSpaceEvent*s. I mean, handling events looked enough to generate a log, and also events are more oriented to react via handlers as a user software.

In that sense, BlParallelUniverseErrorDuringPulseSignal may be replaced by a new BlParallelUniversePulseErrorEvent.

@labordep
Copy link
Contributor

hi @tinchodias, with @Nyan11 we for doing stuff when a space is open with Pyramid (to install a keyboard shortcut to edit it), what event can we used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants