Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jenkins to use Pharo 110 for building #661

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Update Jenkins to use Pharo 110 for building #661

merged 1 commit into from
Aug 2, 2023

Conversation

PalumboN
Copy link
Collaborator

I'm trying to fix the CI :)

@PalumboN
Copy link
Collaborator Author

PalumboN commented Aug 1, 2023

The built VM failed while the PharoTutorialGoOnMockTutorialTest are running because there is a concurrent access between the test and the UI thread.

We can:

  • Ignore the test in the CI
  • Or block the UI thread during these tests

@PalumboN
Copy link
Collaborator Author

PalumboN commented Aug 1, 2023

There are also failing tests:

  • CoverageCollectorTest >> testExample. This test only works in the JITed production VM. We tried using a generated StackVM and the VM generated in this PR and both failed. There is some issue between the CoverageCollector and the VM. We should rewrite/skip this test.

  • There are two tests from FLCreateClassSerializationTest that are failing because of TestTookTooMuchTime. We should mark them as longTestCase.

@PalumboN
Copy link
Collaborator Author

PalumboN commented Aug 2, 2023

Ok, the testExample is already fixes in Pharo12

https://github.com/pharo-project/pharo/blob/44816f8b7f27c6397f1a9b0577430f0f3b90f2a7/src/Coverage/CoverageCollectorTest.class.st#L89-L103

I will backport that (and longTestCase cases) to Pharo11, so the CI should pass all the Pharo tests after that.

@guillep
Copy link
Member

guillep commented Aug 2, 2023

Ok, there is no risk at integrating this. It's the right call.
The failing test is in both Pharo11 and 12, as soon as Pharo11 is fixed this will be fixed too.

This avoids the constant failures on JobXXX that were prevalent in Pharo10.
@PalumboN for next time, try that PRs are self-explanatory :P

We should merge this into Pharo12 branch too.

@guillep guillep merged commit 2007a60 into pharo-10 Aug 2, 2023
1 check passed
@guillep guillep deleted the fix-ci branch August 2, 2023 11:46
@PalumboN
Copy link
Collaborator Author

PalumboN commented Aug 2, 2023

I cannot image a PR more self-explanatory than this:

I'm trying to fix the CI :)

That was the truth, I did not have more info that 🤣

@guillep
Copy link
Member

guillep commented Aug 2, 2023

Yes you did!

This avoids the constant failures on JobXXX that were prevalent in Pharo10.

You told me that Pharo>10 had that test skipped, and that's why you wanted to move!

@PalumboN
Copy link
Collaborator Author

PalumboN commented Aug 2, 2023

Ahh yes! 😅

@PalumboN PalumboN mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants