Backport fixed tests #14409
Merged
Backport fixed tests #14409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One coverage tests has been disabled after failing randomly on the CI. The problems comes from some VM optimizations on the VM. In linux, special selectors are running in the interpreter so the messages Point >> #x and Point >> #y are never executed. In OSX, the method is compiled to machine code and the messages are sent. To have a more robust test, I excluded the special selectors from the list of methods to cover
jecisc
approved these changes
Aug 2, 2023
guillep
approved these changes
Aug 2, 2023
| coverage := collector runOn: [ (1@1 corner: 2@2) center ]. "Setup, execute and teardown." | ||
| self assert: (coverage methods includes: Point>>#x). "Inspect the results" | ||
| self assert: (coverage nodes size > 10). "Covered paths are also available" | ||
| "We skip the method with special selectors because them might not be detected by the coverage collector in case they are optimized by the VM." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport a fixed test + marking two tests as
longTestCase.This is for having the VM CI in GREEN 🟢
See pharo-project/pharo-vm#661