Add library with function to spawn a process connected to a pseudo-terminal #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Rinzwind, @pavel-krivanek nice! The build had a hiccup, I relaunched it. It would be nice however to see some comments in the code. |
tesonep
approved these changes
Feb 17, 2024
…ivation for providing it through a library included with the VM.
…terminal device and setting up the standard file descriptors.
…tty_spawn’ from 1 to 127 (similar to ‘posix_spawn’).
|
I added a comment, fixed the compilation error on Linux (“error: implicit declaration of function 'ptsname'”), and improved the error checks in ‘tty_spawn’. I’m not sure whether the library should be given a more distinct name. There’s an existing ‘libtty’. |
…’ to use ‘_exit’ instead of ‘exit’, and ‘dprintf’ instead of ‘printf’, to avoid flushing the open streams copied, buffers included, from the parent process.
|
Can this be merged? I had to make one more change (commit 6fa0c9e) but I think it’s ready now. I wrote some tests for which I will open a Pharo pull request once ‘libtty’ is available in the VM. |
Merged
Rinzwind
added a commit
to Rinzwind/pharo
that referenced
this pull request
Apr 8, 2024
Rinzwind
added a commit
to lxsang/PTerm
that referenced
this pull request
Apr 19, 2024
Rinzwind
added a commit
to lxsang/PTerm
that referenced
this pull request
Apr 19, 2024
lxsang
pushed a commit
to lxsang/PTerm
that referenced
this pull request
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a small library with a function to spawn a process connected to a pseudo-terminal. As discussed in pavel-krivanek/terminal issue #2 and PTerm issue #58, it’s not entirely possible to replicate this function in-image using
posix_spawn. The function callssetsidandioctlwithTIOCSCTTYin the spawned process. For thesetsidcall, the attribute flagPOSIX_SPAWN_SETSIDcan be passed toposix_spawn(nonstandard but supported by the GNU C Library and macOS). But for theioctlcall there is, as far as I know, no corresponding attribute or file action that can be passed.The new File Browser that is being adopted (see: Pharo pull request #16084) offers a context menu item ‘Open terminal here’. That currently does not allow using PTerm (PTerm issue #62), but it would be nice if it did and if the VM made that convenient to use by providing the necessary supporting library.