Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the old morphic-based FileList #16084

Open
wants to merge 10 commits into
base: Pharo13
Choose a base branch
from

Conversation

hernanmd
Copy link
Member

@hernanmd hernanmd commented Feb 1, 2024

This is just a first PR to remove the FileList based on Morphic. The tool has already a replacement version based in Spec 2 recently integrated and ready to be used.
The new file system lister or browser is implemented in StFileSystemPresenter.

@hernanmd hernanmd self-assigned this Feb 1, 2024
Copy link
Member

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hernanmd Thanks!

This PR is just removing the tool from the listed packages, but it's not removing the package. To do that in Iceberg you need to use the "Remove from repository" option and commit that.

@hernanmd
Copy link
Member Author

hernanmd commented Feb 5, 2024

Hi @hernanmd Thanks!

This PR is just removing the tool from the listed packages, but it's not removing the package. To do that in Iceberg you need to use the "Remove from repository" option and commit that.

Thanks, I will fix this today as there are a couple of users of UITheme that needs translation.

@guillep
Copy link
Member

guillep commented Feb 5, 2024

Hi @hernanmd Thanks!
This PR is just removing the tool from the listed packages, but it's not removing the package. To do that in Iceberg you need to use the "Remove from repository" option and commit that.

Thanks, I will fix this today as there are a couple of users of UITheme that needs translation.

Oh I see this is a work in progress. I'll mark the PR as draft to avoid accidental merges :)

@guillep guillep marked this pull request as draft February 5, 2024 09:57
@hernanmd
Copy link
Member Author

hernanmd commented Feb 6, 2024

Updated. This needs pharo-spec/NewTools#682 prior to be applied.

@jecisc
Copy link
Member

jecisc commented Feb 19, 2024

I resolved the conflict. The PR in NewTools got merged so maybe this PR should not be a draft anymore?

@Ducasse
Copy link
Member

Ducasse commented Mar 12, 2024

As discussed for P13

@hernanmd hernanmd changed the base branch from Pharo12 to Pharo13 June 17, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants