Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monticello: update MCClassTraitDefinition to follow changes of MCClassDefinition #14653

Merged

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented Sep 13, 2023

I recently updated MCClassDefinition and MCTraitDefinition to push two changes:

  • Split the huge constructors to make the instance configurable
  • Add #packageName and #tagName variables in order to allow to configure the definition with packages and tags instead of categories even if the code is still exploiting the #category method.

This change will allow me to update Tonel to use packages and tags and once this is done we will be able to remove the depend code of categories to really exploit the #packageName and #tagName variables.

@jecisc
Copy link
Member Author

jecisc commented Sep 13, 2023

Hum... I did this in an image that already has my changes on Tonel which messed up the format. I'll try to fix that

@Ducasse Ducasse merged commit a72d979 into pharo-project:Pharo12 Sep 14, 2023
1 check passed
@jecisc jecisc deleted the monticello/update-class-trait-definition branch September 15, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants