Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tonel to not depend on the category API of RPackage #110

Merged
merged 15 commits into from
Sep 14, 2023

Conversation

jecisc
Copy link
Contributor

@jecisc jecisc commented Sep 13, 2023

This PR bring a big change in Tonel in order to not use the category API of RPackage.

The goal is to go away from the "category" that is a mix of package name and tag name in the system while staying backward compatible with older versions of Pharo and other Smalltalks.

Change in the writer

The first change happened in the writer. It now exports two new metadata in the types:

  • #package that is the name of the package of the type
  • #tag that is optional. In case the class is not in the root tag, it will export the name of the tag

The #category metadata is still here for compatibility reasons with the older versions of Pharo and other Smalltalks

Change in the reader

Now the parser is looking for the new #package and #tag metadatas. In case it does not find it, it will put the category in the #packageName variable of MCClassDefinition. Then the TonelReader will do a pass on the class definitions to ensure the package is right. In case the package named found does not match the real package name and the real package name is just a prefix of it, it will fix the package name and the tag name.

Other changes

I also update Tonel to follow the changes that happened in Monticello recently

In order to work this change needs pharo-project/pharo#14653

@jecisc
Copy link
Contributor Author

jecisc commented Sep 13, 2023

This is weird because since Pharo 11 the tonel project is not loadable by smalltalk CI

@jecisc jecisc changed the base branch from master to Pharo12 September 14, 2023 12:18
@jecisc jecisc merged commit ec3a5fe into pharo-vcs:Pharo12 Sep 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant