Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink Feature #1: Automatic Hyperlink Generation for Scenario Titles #320

Closed
ajhuntsman opened this issue Apr 11, 2016 · 8 comments
Closed

Comments

@ajhuntsman
Copy link

Per @dirkrombauts (#317 (comment)), each Scenario's title should be rendered as a hyperlink to that Scenario.

By default, the hyperlink will be generated using the Scenario's title.

@dirkrombauts
Copy link
Member

Thanks for creating the issue. It would actually be sufficient to include the id attribute to the heading of the scenario title.

Assuming we have a scenario like

Scenario: I'm Blue

Then for the static html version, we should generate

<h2 id="im-blue">I'm Blue</h2>

The dynamic html version can be done in a similar way.

@eleite77
Copy link

eleite77 commented May 3, 2016

Hi @dirkrombauts
I am trying to implement that even i don't know well the project itself.

Do you think for this enhancement it is possible to detect a scenario parameter in the url (like scenario=title) and to filter the data in the JsonPWrapper javascript function?
The data.features array will only contain one entry : the filtered feature (passed by the Anchor #).
The function will also loop into the field "FeaturesElements" of the feature in order to retrieve only the good scenario and remove the others.
Then the new JSON object will be passed to the JsonPWrapper which will process the new object.

What do you think?
Could it be an easy way to implement that?
Thanks
E. Leite

@dirkrombauts
Copy link
Member

@eleite77 thank you for the suggestion. To be perfectly honest, I don't know my way around the DHTML version all that much, so I cannot answer your question whether it would be easy to implement this.

@aaronjrich
Copy link

@dirkrombauts and @eleite77: I took a look at this at bit ago to assess the effort in the "DHTML" version doing something like a query string to link directly to a scenario. In the current implementation, "#folder/featurefile.feature" was used on the URL to deep link to particular features. The nice part of using that was that it was easy to get at that last part of the url, you just call window.location.hash, and bam, you have the feature file name to filter for. In hindsight, given this new request, it would have been better to use a query string like structure to allow for more flexibility, but query strings are not nearly as easy to use on the client side. I think it could be converted to that without too much effort but I worry a bit that, 1, some people may be expecting the hash url structure and 2, I'm not sure what to use for the anchor name and still have it be discoverable. I tried using the scenario title, but then struggled a bit when weird characters were in the title (perhaps this was causing an issue: http://stackoverflow.com/questions/70579/what-are-valid-values-for-the-id-attribute-in-html/31773673#31773673). Based on the Dirk's example above, all weird characters could get stripped away - perhaps that would help things.

I may take another stab at this when I have some time unless someone else would like to jump on this before me.

@ocsurfnut
Copy link

@dirkrombauts , @aaronjrich , @eleite77 , @ajhuntsman ... this is a feature I am interested in as well, and I actually find myself with a little free time this week. Is anyone already working on this? If not, would it be okay if I take this ball and run with it (based on suggestions above)?

@aaronjrich
Copy link

@ocsurfnut, go for it, I haven't been able to get after this.

@dirkrombauts
Copy link
Member

@ocsurfnut I'm not working on it either, so go for it!

dirkrombauts pushed a commit that referenced this issue Jun 20, 2016
* #320 - Scenario Deep Linking - DHTML and HTML Output

* #320 - Fix Failing Unit Tests

* #320 - Resolved Issue with Image Resource Not Copying

* #320 - Add Backward-Compatibility for Hashed Feature Path

* #320 - Added Modal Dialog for Link Copy
dirkrombauts added a commit that referenced this issue Jun 29, 2016
* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Release 2.7.0 (#352)

* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* #320 - Scenario Deep Linking - DHTML and HTML Output (#350)

* #320 - Scenario Deep Linking - DHTML and HTML Output

* #320 - Fix Failing Unit Tests

* #320 - Resolved Issue with Image Resource Not Copying

* #320 - Add Backward-Compatibility for Hashed Feature Path

* #320 - Added Modal Dialog for Link Copy

* Edit release notes

* Version Bump (2.8.0)
@dirkrombauts
Copy link
Member

Released in version 2.8.0.

dirkrombauts added a commit that referenced this issue Sep 28, 2016
* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Release 2.7.0 (#351)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* Release 2.8.0 (#355)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Release 2.7.0 (#352)

* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* #320 - Scenario Deep Linking - DHTML and HTML Output (#350)

* #320 - Scenario Deep Linking - DHTML and HTML Output

* #320 - Fix Failing Unit Tests

* #320 - Resolved Issue with Image Resource Not Copying

* #320 - Add Backward-Compatibility for Hashed Feature Path

* #320 - Added Modal Dialog for Link Copy

* Edit release notes

* Version Bump (2.8.0)

* Release 2.8.1 (#360)

* Add release notes

* Fix some markdown syntax things

* Bump version number (2.8.3)

* Version 2.8.3
dirkrombauts added a commit that referenced this issue Oct 7, 2016
* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Release 2.7.0 (#351)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* Release 2.8.0 (#355)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Release 2.7.0 (#352)

* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* #320 - Scenario Deep Linking - DHTML and HTML Output (#350)

* #320 - Scenario Deep Linking - DHTML and HTML Output

* #320 - Fix Failing Unit Tests

* #320 - Resolved Issue with Image Resource Not Copying

* #320 - Add Backward-Compatibility for Hashed Feature Path

* #320 - Added Modal Dialog for Link Copy

* Edit release notes

* Version Bump (2.8.0)

* Release 2.8.1 (#360)

* Release 2.8.3 (#376)

* Delete CNAME as advised by github support

* Create CNAME

* Get rid of ngenerics (#370)

* Use Tree instead of NGenerics.GeneralTree

* Use visitor instead of ActionVisitor

* Rename Visitor to Traversor

* Remove reference to unused NGenerics library

* Fix whitespace

* Remove NGenerics from nuspecs and build scripts

* Get rid of traversor

* Compatibility with nunit.console 3.4 and nunit.framework 2.6 (#369)

* Compatibility with nunit.console 3.4 and nunit.framework 2.6

* Added example output file and test for nunit 2 tests ran with nunit 3 runner.

* Add "NUnit 2 tests run by NUnit 3" to test harness (#371)

* Move generation and commit of output to DeployArtifacts (#372)

* Added test for sorting when generating word docs (#373)

* Added test for sorting when generating word docs

* Use stream overloads of WordprocessingDocument

* Improve tree (#374)

* Add test about sorting

* Make it compile

* Make it pass

* Check for null in constructor

* Add test about null names in iteration

* Factory method for creating trees

* Check for null tree when adding

* Add test for null node

* Add release notes

* Fix some markdown syntax things

* Bump version number (2.8.3)

* Version 2.8.3

* Version Bump (2.9.0)
dirkrombauts added a commit that referenced this issue Oct 7, 2016
* Delete CNAME as advised by github support

* Create CNAME

* Get rid of ngenerics (#370)

* Use Tree instead of NGenerics.GeneralTree

* Use visitor instead of ActionVisitor

* Rename Visitor to Traversor

* Remove reference to unused NGenerics library

* Fix whitespace

* Remove NGenerics from nuspecs and build scripts

* Get rid of traversor

* Compatibility with nunit.console 3.4 and nunit.framework 2.6 (#369)

* Compatibility with nunit.console 3.4 and nunit.framework 2.6

* Added example output file and test for nunit 2 tests ran with nunit 3 runner.

* Add "NUnit 2 tests run by NUnit 3" to test harness (#371)

* Move generation and commit of output to DeployArtifacts (#372)

* Added test for sorting when generating word docs (#373)

* Added test for sorting when generating word docs

* Use stream overloads of WordprocessingDocument

* Improve tree (#374)

* Add test about sorting

* Make it compile

* Make it pass

* Check for null in constructor

* Add test about null names in iteration

* Factory method for creating trees

* Check for null tree when adding

* Add test for null node

* Release 2.8.3 (#377)

* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Release 2.7.0 (#351)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* Release 2.8.0 (#355)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Release 2.7.0 (#352)

* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* #320 - Scenario Deep Linking - DHTML and HTML Output (#350)

* #320 - Scenario Deep Linking - DHTML and HTML Output

* #320 - Fix Failing Unit Tests

* #320 - Resolved Issue with Image Resource Not Copying

* #320 - Add Backward-Compatibility for Hashed Feature Path

* #320 - Added Modal Dialog for Link Copy

* Edit release notes

* Version Bump (2.8.0)

* Release 2.8.1 (#360)

* Add release notes

* Fix some markdown syntax things

* Bump version number (2.8.3)

* Version 2.8.3

* Special chars need to be replaced (#375)

* Special chars need to be replaced

There are some more special chars (especially german Umlaute) that need to be replaced for the match to be successfull.

* Special chars need to be replaced #375
Creating test cases and fixing handling of umlauts and ampersand

* Changed indentation

* Fix Importing Test Results failure for MsTest (#378)

* + fix null featureTreeNode in ApplyTestResultsToFeature
+ handle null value for GetExampleResults and defaulted to TestResult.Inconclusive

* + added extra test scenario for MsTest with ignored ScenarioOutline examples

* + refactored LINQ for FeatureNode in ApplyTestResultsToFeatures

* Show parser failures and quit with an error (#379)

* Don't swallow exceptions if parsing a feature file throws. If parsing fails we want the build to break. We don't want to silently ignore parts.

* Improve NLog layout for console
- Don't show datetime, loglevel and logger
- Use colors
- Show exception messages

* Version Bump (2.9.0)
dirkrombauts added a commit that referenced this issue Oct 7, 2016
* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Release 2.7.0 (#351)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* Release 2.8.0 (#355)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Release 2.7.0 (#352)

* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* #320 - Scenario Deep Linking - DHTML and HTML Output (#350)

* #320 - Scenario Deep Linking - DHTML and HTML Output

* #320 - Fix Failing Unit Tests

* #320 - Resolved Issue with Image Resource Not Copying

* #320 - Add Backward-Compatibility for Hashed Feature Path

* #320 - Added Modal Dialog for Link Copy

* Edit release notes

* Version Bump (2.8.0)

* Release 2.8.1 (#360)

* Release 2.8.3 (#376)

* Delete CNAME as advised by github support

* Create CNAME

* Get rid of ngenerics (#370)

* Use Tree instead of NGenerics.GeneralTree

* Use visitor instead of ActionVisitor

* Rename Visitor to Traversor

* Remove reference to unused NGenerics library

* Fix whitespace

* Remove NGenerics from nuspecs and build scripts

* Get rid of traversor

* Compatibility with nunit.console 3.4 and nunit.framework 2.6 (#369)

* Compatibility with nunit.console 3.4 and nunit.framework 2.6

* Added example output file and test for nunit 2 tests ran with nunit 3 runner.

* Add "NUnit 2 tests run by NUnit 3" to test harness (#371)

* Move generation and commit of output to DeployArtifacts (#372)

* Added test for sorting when generating word docs (#373)

* Added test for sorting when generating word docs

* Use stream overloads of WordprocessingDocument

* Improve tree (#374)

* Add test about sorting

* Make it compile

* Make it pass

* Check for null in constructor

* Add test about null names in iteration

* Factory method for creating trees

* Check for null tree when adding

* Add test for null node

* Add release notes

* Fix some markdown syntax things

* Bump version number (2.8.3)

* Version 2.8.3

* Version Bump (2.9.0)

* Version 2.9.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants