Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Dealing with Special Characters in Scenario Examples #375

Merged
merged 4 commits into from
Sep 29, 2016

Conversation

thopark
Copy link

@thopark thopark commented Sep 27, 2016

There are some more special chars (especially german Umlaute) that need to be replaced for the match to be successfull.

There are some more special chars (especially german Umlaute) that need to be replaced for the match to be successfull.
@dirkrombauts
Copy link
Member

Thanks for your contribution!
The scenario matcher is one of the most delicate parts in Pickles, so there is a battery of tests about it. It is my policy to only accept changes if the tests are adapted as well.

The CONTRIBUTING.md file contains a description on how to contribute to the test result providers. Please let me know if you need more information than what's in there.

And I suggest you consider including ß in your list as well :-)

Copy link
Member

@dirkrombauts dirkrombauts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only thing I would like you to change is the indentation. Please use the same indentation as the rest of the project.

@dirkrombauts dirkrombauts merged commit b2d5f58 into picklesdoc:develop Sep 29, 2016
@dirkrombauts
Copy link
Member

Thanks for your contribution. I'll try to release a new version next week.

@thopark thopark deleted the patch-1 branch September 29, 2016 13:03
@dirkrombauts dirkrombauts changed the title Special chars need to be replaced Better Dealing with Special Characters in Scenario Examples Oct 7, 2016
This was referenced Oct 7, 2016
dirkrombauts added a commit that referenced this pull request Oct 7, 2016
* Delete CNAME as advised by github support

* Create CNAME

* Get rid of ngenerics (#370)

* Use Tree instead of NGenerics.GeneralTree

* Use visitor instead of ActionVisitor

* Rename Visitor to Traversor

* Remove reference to unused NGenerics library

* Fix whitespace

* Remove NGenerics from nuspecs and build scripts

* Get rid of traversor

* Compatibility with nunit.console 3.4 and nunit.framework 2.6 (#369)

* Compatibility with nunit.console 3.4 and nunit.framework 2.6

* Added example output file and test for nunit 2 tests ran with nunit 3 runner.

* Add "NUnit 2 tests run by NUnit 3" to test harness (#371)

* Move generation and commit of output to DeployArtifacts (#372)

* Added test for sorting when generating word docs (#373)

* Added test for sorting when generating word docs

* Use stream overloads of WordprocessingDocument

* Improve tree (#374)

* Add test about sorting

* Make it compile

* Make it pass

* Check for null in constructor

* Add test about null names in iteration

* Factory method for creating trees

* Check for null tree when adding

* Add test for null node

* Release 2.8.3 (#377)

* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Release 2.7.0 (#351)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* Release 2.8.0 (#355)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Release 2.7.0 (#352)

* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* #320 - Scenario Deep Linking - DHTML and HTML Output (#350)

* #320 - Scenario Deep Linking - DHTML and HTML Output

* #320 - Fix Failing Unit Tests

* #320 - Resolved Issue with Image Resource Not Copying

* #320 - Add Backward-Compatibility for Hashed Feature Path

* #320 - Added Modal Dialog for Link Copy

* Edit release notes

* Version Bump (2.8.0)

* Release 2.8.1 (#360)

* Add release notes

* Fix some markdown syntax things

* Bump version number (2.8.3)

* Version 2.8.3

* Special chars need to be replaced (#375)

* Special chars need to be replaced

There are some more special chars (especially german Umlaute) that need to be replaced for the match to be successfull.

* Special chars need to be replaced #375
Creating test cases and fixing handling of umlauts and ampersand

* Changed indentation

* Fix Importing Test Results failure for MsTest (#378)

* + fix null featureTreeNode in ApplyTestResultsToFeature
+ handle null value for GetExampleResults and defaulted to TestResult.Inconclusive

* + added extra test scenario for MsTest with ignored ScenarioOutline examples

* + refactored LINQ for FeatureNode in ApplyTestResultsToFeatures

* Show parser failures and quit with an error (#379)

* Don't swallow exceptions if parsing a feature file throws. If parsing fails we want the build to break. We don't want to silently ignore parts.

* Improve NLog layout for console
- Don't show datetime, loglevel and logger
- Use colors
- Show exception messages

* Version Bump (2.9.0)
@dirkrombauts
Copy link
Member

Released in version 2.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants