Fix path handling for Unix and Mac

[jboffel]

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

[dirkrombauts]

Hi,
Thanks for the feedback about Mono. I know that in theory it should be possible but I've never done it myself. Would you be willing to tell me a bit more about how "Pickles on Mono" works? If so, please send me an email at dirk dot rombauts at picklesdoc dot com.

About the modification: I'll be glad to integrate this, but I have two questions:

1. In splitDirectoryPathIntoArrayOfFormattedFolders you use a regular expression, but in folderHasSubdirectory you use two separate statements. I'm neither a regex expert nor a javascript one, so could you educate me on your reasons?
2. Do we perhaps need a similar change in the other output formats?

[jboffel]

About the js modification, I always try to save the number of function call and the regexp let me check for as many path delimiter as i wish. It then even work for potential weird composite path that may happen from time to time like c:\some/thing
For indexOf I use two separate call as unfortunately it does not support regexp...

Also I tried some of the other output format and it doesn't seems to be an issue for them. Mostly for the dhtml the modification happen to be just on the javascript parser actually.

[dirkrombauts]

I just tried this out on my mac ... the features in the directories are shown, but the directories themselves are not shown - like in the image:

Does it look like that on Linux too?

[jboffel]

Before my fix and if the json file was generated on Linux system through
mono yes it was like that.

With my fix now if generated on Linux with mono it has the directory.
However the image is not well created then you get those weird out looking
for your icons like next of links in the nav menu.

If despite my fix it does not works well on Mac I'll try to have a look on
mine.

Regards
On May 14, 2016 3:23 AM, "Dirk Rombauts" [email protected] wrote:

I just tried this out on my mac ... the features in the directories are
shown, but the directories themselves are not shown - like in the image:
[image: screen shot 2016-05-13 at 20 22 06]
https://cloud.githubusercontent.com/assets/975415/15257810/7ad2d48a-1948-11e6-9683-a63af5b958eb.png

Does it look like that on Linux too?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#344 (comment)

[dirkrombauts]

Ah, yes, silly me - I was testing the latest released version. That doesn't include your change yet. I'll try again with the latest development version soon.

[dirkrombauts]

I tested the correct version now :-) The directories are shown, and there are indeed problems with the images as you pointed out.
One thing is weird, though: the highest level folder is called ".." instead of "Features" - both in the tree on the left side and in the links to the individual features. A look at the generated pickledFeatures.js reveals that the same is the case there. So it's not caused by your changes in the heirarchyBuilder.js file, but rather by something in Pickles. Does the same happen on Linux?

[jboffel]

Well yes and no, it seems it depends on mono version. Old one for unknown
reason will make pickles create a path with ..
But last one on recent Ubuntu seems to not prepend those two ..
So I'd bet Mac mono version is an old one.

Regards
On May 15, 2016 1:53 AM, "Dirk Rombauts" [email protected] wrote:

I tested the correct version now :-) The directories are shown, and there
are indeed problems with the images as you pointed out.
One thing is weird, though: the highest level folder is called ".."
instead of "Features" - both in the tree on the left side and in the links
to the individual features. A look at the generated pickledFeatures.js
reveals that the same is the case there. So it's not caused by your changes
in the heirarchyBuilder.js file, but rather by something in Pickles. Does
the same happen on Linux?

[image: screen shot 2016-05-14 at 18 43 40]
https://cloud.githubusercontent.com/assets/975415/15269624/2a0359b8-1a05-11e6-9641-27eae7bf9ac7.png

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#344 (comment)

[dirkrombauts]

I have Mono Mac v 4.2.3.4 which should be the latest version. sigh

Could you please post a screenshot of the result on Linux with the latest and greatest mono? I would like to see the result but I don't fancy setting up a Linux VM just for that :-(

[dirkrombauts]

Released in version 2.6.3.