Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not so understandable codeCheck results #21

Closed
orichters opened this issue Jun 7, 2022 · 4 comments · Fixed by #92
Closed

not so understandable codeCheck results #21

orichters opened this issue Jun 7, 2022 · 4 comments · Fixed by #92
Assignees
Labels
bug Something isn't working

Comments

@orichters
Copy link
Contributor

orichters commented Jun 7, 2022

Two things I identified with @robinhasse:


If a global switch is added to a not_used.txt (which apparently is not desired), the error message is:

2: Could not find any declaration for cm_rcp_scen_build

See https://github.com/remindmodel/remind/runs/6772164690. A better error message would be really desirable. By the way, where can I find a description of what is supposed to enter not_used.txt?


If code looks like that, note the indentation with blanks:

  Parameter
  p_extRegiccsinjecrateRegi(ext_regi) "Regional CCS injection rate factor. 1/a. (extended regions)" / %c_ccsinjecrateRegi% /;

a warning is raised as in this remind PR check, stating:

: "Parameter" does not follow the given naming convetions (description = "")!

But strangely enough, this warning does not impede the script from stating All codeCheck tests passed!. Maybe, because the warning has no parameter name but rather an empty string? It would be appreciated if incorrect blanks before stating "Parameter" etc. would get a more understandable error code.

@giannou
Copy link
Contributor

giannou commented Jun 8, 2022

where can I find a description of what is supposed to enter not_used.txt?

A somewhat hidden description is found here

@giannou
Copy link
Contributor

giannou commented Jun 9, 2022

Regarding the indentation with blanks: it happens also elsewhere in the code so maybe it's not what generates the warning? [Update: the indentation with blanks causes the warning]

How about the slash / in the description field? In any case I'm looking also into that and will report back soon [Update: looks like this is also normal]

@orichters
Copy link
Contributor Author

@giannou
Copy link
Contributor

giannou commented Jun 17, 2022

The

indentation with blanks

issue was fixed with #25.

The

If a global switch is added to a not_used.txt

issue seems to be a bug and will be treated and discussed further here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants