Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix in manipulateConfig #89

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Conversation

tscheypidi
Copy link
Member

bugfix in manipulateConfig (GAMS allows "/" in quoted comments but not in unquoted comments)

This fixes issue #88

@orichters
Copy link
Contributor

Thanks, @tscheypidi, for the quick reaction.

  • I did some tests using Regex Coach with the new setting and it looks very good.
  • I checked the new version on REMIND main.gms, added some / here and there and it works as intended.
  • According to gams.com, either single or double quotes may be used. Is it worth to replace (\"[^\"]*\"|) by (\"[^\"]*\"|\'[^\']*\'|) or something like that? In REMIND, double quotes seem to be used consistently.

@tscheypidi
Copy link
Member Author

I could imagine that someone uses the single quotes within the double quotes which would mess up the detection again. So I suggest to stick to double quotes only

Copy link
Contributor

@orichters orichters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is indeed true. I checked REMIND again and couldn't find any declaration using single quotes. Maybe I will approach Lavinia and tell her we should put that in the coding etiquette such that it remains this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants