Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct GAMS indentation reading, add package help page #25

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

giannou
Copy link
Contributor

@giannou giannou commented Jun 14, 2022

No description provided.

@giannou giannou requested a review from tscheypidi June 14, 2022 10:22
@tscheypidi
Copy link
Member

did you test that this change does not break anything in REMIND and MAgPIE?

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #25 (665cbf9) into master (ddebbf1) will not change coverage.
The diff coverage is 29.41%.

❗ Current head 665cbf9 differs from pull request most recent head 384a22e. Consider uploading reports for the commit 384a22e to get more accurate results

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   31.24%   31.24%           
=======================================
  Files          44       44           
  Lines        1434     1434           
=======================================
  Hits          448      448           
  Misses        986      986           
Impacted Files Coverage Δ
R/codeCheck.R 49.14% <25.00%> (ø)
R/readDeclarations.R 82.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddebbf1...384a22e. Read the comment docs.

@giannou
Copy link
Contributor Author

giannou commented Jun 14, 2022

did you test that this change does not break anything in REMIND and MAgPIE?

codeCheck generates no warnings for both models, but I'll also start test runs to be completely sure. good point

@giannou
Copy link
Contributor Author

giannou commented Jun 15, 2022

Both models run smoothly

@giannou giannou merged commit 4b0200f into pik-piam:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants