Add Calibration reporting and plotting #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation structure with three internal functions in the Rmd
robinhasse
approved these changes
May 24, 2024
ricardarosemann
commented
May 27, 2024
|
|
||
| out[["flowDevHsRel"]] <- .computeRelDev(out[["flowDevHs"]], list(p_constructionHist, p_renovationHist), | ||
| tCalib, notInHist = "hsr") | ||
|
|
There was a problem hiding this comment.
I modified the computation of the relative deviations by heating system - the idea is that the denominator is computed as the sum of the squares of the historic stock/flow of all heating systems, not just the heating system we are looking at. Therefore, the column hsr is excluded from the grouping when computing the sum of the squares.
ricardarosemann
commented
May 27, 2024
| .computeRelDev <- function(dfDev, dfHist, tCalib, notInHist = NULL) { | ||
|
|
||
| # Determine the reported columns in the calibration data | ||
| rprt <- setdiff(colnames(dfDev), c("iteration", "value", notInHist)) |
There was a problem hiding this comment.
This function was adapted to allow for the modified computation of relative deviations by hs.
|
I adapted the computation of relative deviations by heating system a little, see also the comments in the code. Therefore a brief review would be great. |
robinhasse
approved these changes
May 28, 2024
| .computeRelDev <- function(dfDev, dfHist, tCalib, notInHist = NULL) { | ||
|
|
||
| # Determine the reported columns in the calibration data | ||
| rprt <- setdiff(colnames(dfDev), c("iteration", "value", notInHist)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a reporting function for the calibration and a corresponding plotting routine.
The function
reportCalibrationreports relevant quantities from the Brick calibration by doing the following:The plotting routine consists of the function
plotBRICKCaliband the R markdownplotsCalibration.Rmd.plotBRICKCalibassembles the paths to the files to be read in (usually output ofreportCalibration) and renders the markdown file