Add FE and UE reporting for space heating #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardarosemann
approved these changes
May 27, 2024
| tot <- paste0(en, "|Residential|Space heating") | ||
| vars <- paste(tot, carrier, sep = "|") | ||
| showAreaAndBarPlots(data, vars = vars, tot = tot, orderVars = "user", scales = "fixed") | ||
| walk(vars, showLinePlots, data = data) |
There was a problem hiding this comment.
I'm a bit confused how the script (and the reader) knows that this is the purrr function walk (I guess)? Maybe because purrr just happens to be loaded by some other package? For PR #4 I had to add purrr as an imported package anyway, so you can probably safely write purrr::walk here and elsewhere.
There was a problem hiding this comment.
Thanks Ricarda for pointing this out. I'm really not sure how to handle dependencies from the scripts properly. I decided to load packages with explicit lists of functions in inst/compareScenarios/preprocessing.R for compareScenarios.
There was a problem hiding this comment.
And now purrr::walk is part of it, too ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rough first implementation. I'm still quite unsure what variables and plots are useful. We'll find out over time...