Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dep: update parser and other dependencies to latest #1289

Merged
merged 20 commits into from
Nov 27, 2020
Merged

dep: update parser and other dependencies to latest #1289

merged 20 commits into from
Nov 27, 2020

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Nov 20, 2020 •
edited
Loading

What problem does this PR solve?

close #1227

What is changed and how it works?

update parser (and other dependencies) to latest.

change uuid to google/uuid

Check List

Tests

  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@lance6716 lance6716 mentioned this pull request Nov 20, 2020
Closed
@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 type/dependencies Pull requests that update a dependency file labels Nov 20, 2020
@lance6716 lance6716 changed the title dep: update parser to latest dep: update parser and other dependencies to latest Nov 20, 2020
@lance6716
Copy link
Collaborator Author

waiting PingCAP-QE/go-sqlsmith#9 (not sure why go.mod in go-sqlsmith doesn't take effect)

csuzhangxc
csuzhangxc reviewed Nov 20, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added the status/LGT1 One reviewer already commented LGTM label Nov 20, 2020
@csuzhangxc csuzhangxc added this to the v2.0.1 milestone Nov 20, 2020
@lance6716 lance6716 added the status/DNM Do not merge, test is failing or blocked by another PR label Nov 20, 2020
@lance6716

This comment has been minimized.

Sign in to view
@lance6716

This comment has been minimized.

Sign in to view
@lance6716 lance6716 mentioned this pull request Nov 20, 2020
Merged
@lance6716 lance6716 added status/DNM Do not merge, test is failing or blocked by another PR and removed status/DNM Do not merge, test is failing or blocked by another PR labels Nov 23, 2020
@lance6716

This comment has been minimized.

Sign in to view
@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716
Copy link
Collaborator Author

/run-compatibility-tests

@lance6716 lance6716 removed the status/DNM Do not merge, test is failing or blocked by another PR label Nov 25, 2020
@lance6716
Copy link
Collaborator Author

CI will pass soon, ping @GMHDBJD

csuzhangxc
csuzhangxc reviewed Nov 25, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716
Copy link
Collaborator Author

/run-all-tests

DATA RACE is recorded

@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716
Copy link
Collaborator Author

PTAL @GMHDBJD

lichunzhu
lichunzhu approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 merged commit d504c28 into pingcap:master Nov 27, 2020
@lance6716 lance6716 deleted the update-parser-2 branch November 27, 2020 08:58
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Nov 27, 2020
@lance6716 @ti-srebot
cherry pick pingcap#1289 to release-2.0
bb2a520 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Nov 27, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1313

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Nov 27, 2020
csuzhangxc pushed a commit that referenced this pull request Nov 27, 2020
@ti-srebot @lance6716
dep: update parser and other dependencies to latest (#1289) (#1313)
d196641 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: lance6716 <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked status/LGT1 One reviewer already commented LGTM type/dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging this pull request may close these issues.

Track parser support multiple table rename
5 participants
@lance6716 @ti-srebot @csuzhangxc @lichunzhu @GMHDBJD