Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dep: update parser to lastest #1230

Closed
wants to merge 3 commits into from

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Oct 28, 2020

What problem does this PR solve?

close #1227

What is changed and how it works?

update parser (and its needed library) to latest.

Check List

Tests

  • No code

Code changes

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release branch

@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 type/dependencies Pull requests that update a dependency file labels Oct 28, 2020
@lance6716
Copy link
Collaborator Author

I suspect that tidb-tools need to update some code, to keep compatibility of pingcap/parser#1021 . now some test failed because of sync-diff error

@lance6716 lance6716 added the status/DNM Do not merge, test is failing or blocked by another PR label Oct 28, 2020
@csuzhangxc
Copy link
Member

I suspect that tidb-tools need to update some code, to keep compatibility of pingcap/parser#1021 . now some test failed because of sync-diff error

If it's too hard to fix, we may keep parser as the current version for this 2.0.0 release.

@lance6716
Copy link
Collaborator Author

/run-all-tests

some test runs slowly (both ci and my local)

@lance6716
Copy link
Collaborator Author

for sequence_sharding: need to add a sleep 10 to pass check_sync_diff (pass at retry 7th). I suspect that there's a performance regression, we should not merge this PR before further test

@lance6716 lance6716 mentioned this pull request Oct 29, 2020
11 tasks
@lance6716
Copy link
Collaborator Author

replaced by #1289

@lance6716 lance6716 closed this Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 status/DNM Do not merge, test is failing or blocked by another PR type/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track parser support multiple table rename
2 participants