Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

test: improve stability for tests #785

Merged
merged 11 commits into from
Jul 8, 2020
Merged

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Jul 7, 2020

What problem does this PR solve?

part of #773

What is changed and how it works?

dynamic increase waiting time (by retry) for
testForEtcd.TestInfoEtcd, testForEtcd.TestOperationEtcd, testOptimist.testOptimist, sharding2

increase lease TTL for
testMockScheduler

add notes for
testMaster.TestOfflineMember, testForEtcd.TestWorkerKeepAlive, testMockScheduler, ha_cases

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

@lance6716 lance6716 added priority/unimportant Really minor change, requires approval from secondary reviewers status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix labels Jul 7, 2020
@lance6716 lance6716 mentioned this pull request Jul 7, 2020
28 tasks
@lance6716
Copy link
Collaborator Author

/run-all-tests

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #785 into master will increase coverage by 0.0674%.
The diff coverage is 54.6169%.

@@               Coverage Diff                @@
##             master       #785        +/-   ##
================================================
+ Coverage   57.0981%   57.1656%   +0.0674%     
================================================
  Files           205        206         +1     
  Lines         21104      21345       +241     
================================================
+ Hits          12050      12202       +152     
- Misses         7890       7955        +65     
- Partials       1164       1188        +24     

@lance6716 lance6716 changed the title test: improve stability for unit tests test: improve stability for tests Jul 7, 2020
@lance6716
Copy link
Collaborator Author

PTAL @WangXiangUSTC @GMHDBJD

@lance6716
Copy link
Collaborator Author

/run-all-tests

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

pkg/shardddl/pessimism/info_test.go Outdated Show resolved Hide resolved
dm/master/shardddl/optimist_test.go Show resolved Hide resolved
dm/master/shardddl/optimist_test.go Show resolved Hide resolved
dm/master/shardddl/optimist_test.go Show resolved Hide resolved
pkg/shardddl/pessimism/operation_test.go Show resolved Hide resolved
@WangXiangUSTC
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Jul 8, 2020
@ti-srebot
Copy link

@WangXiangUSTC,Thanks for your review.

@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Jul 8, 2020

/run-all-tests

Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD merged commit 36f175c into pingcap:master Jul 8, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC milestone Jul 15, 2020
@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jul 16, 2020
@lance6716 lance6716 added the needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 label Jul 17, 2020
@ti-srebot
Copy link

cherry pick to release-1.0 failed

@lance6716 lance6716 removed the needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 label Jul 17, 2020
@lance6716 lance6716 deleted the reduce-ci-fail branch July 6, 2021 02:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants