This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
added
priority/unimportant
Really minor change, requires approval from secondary reviewers
status/PTAL
This PR is ready for review. Add this label back after committing new changes
type/bug-fix
Bug fix
labels
Jul 16, 2020
csuzhangxc
reviewed
Jul 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
csuzhangxc
added
status/LGT1
One reviewer already commented LGTM
and removed
status/PTAL
This PR is ready for review. Add this label back after committing new changes
labels
Jul 17, 2020
@lance6716 should we need to cherry-pick this to release-1.0? |
Oh, I forget to cherry pick these test-fix PR 😭 |
lance6716
added
the
needs-cherry-pick-release-1.0
This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0
label
Jul 17, 2020
this PR should be cherry-pick, #785 mainly changed HA tests so need not cherry-pick |
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
================================================
- Coverage 57.0981% 56.4963% -0.6019%
================================================
Files 205 209 +4
Lines 21104 21720 +616
================================================
+ Hits 12050 12271 +221
- Misses 7890 8255 +365
- Partials 1164 1194 +30 |
GMHDBJD
approved these changes
Jul 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
cherry pick to release-1.0 in PR #809 |
ti-srebot
added
already-cherry-pick-1.0
The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked
and removed
needs-cherry-pick-release-1.0
This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0
labels
Jul 17, 2020
GMHDBJD
added
status/LGT2
Two reviewers already commented LGTM, ready for merge
and removed
status/LGT1
One reviewer already commented LGTM
labels
Jul 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
already-cherry-pick-1.0
The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked
priority/unimportant
Really minor change, requires approval from secondary reviewers
status/LGT2
Two reviewers already commented LGTM, ready for merge
type/bug-fix
Bug fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
improve stability of
testSubTask.TestPauseAndResumeSubtask
, which fails at https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/dm_ghpr_test/detail/dm_ghpr_test/5611/pipeline/70/What is changed and how it works?
wait more time
Check List
Tests
Code changes
Side effects
Related changes