Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

test: fix TestPauseAndResumeSubtask #805

Merged
merged 3 commits into from
Jul 17, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

improve stability of testSubTask.TestPauseAndResumeSubtask, which fails at https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/dm_ghpr_test/detail/dm_ghpr_test/5611/pipeline/70/

What is changed and how it works?

wait more time

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

@lance6716 lance6716 added priority/unimportant Really minor change, requires approval from secondary reviewers status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix labels Jul 16, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jul 17, 2020
@csuzhangxc csuzhangxc requested a review from GMHDBJD July 17, 2020 07:41
@csuzhangxc
Copy link
Member

@lance6716 should we need to cherry-pick this to release-1.0?

@lance6716
Copy link
Collaborator Author

@lance6716 should we need to cherry-pick this to release-1.0?

Oh, I forget to cherry pick these test-fix PR 😭

@lance6716 lance6716 added the needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 label Jul 17, 2020
@lance6716
Copy link
Collaborator Author

@lance6716 should we need to cherry-pick this to release-1.0?

this PR should be cherry-pick, #785 mainly changed HA tests so need not cherry-pick

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #805 into master will decrease coverage by 0.6018%.
The diff coverage is 39.5876%.

@@               Coverage Diff                @@
##             master       #805        +/-   ##
================================================
- Coverage   57.0981%   56.4963%   -0.6019%     
================================================
  Files           205        209         +4     
  Lines         21104      21720       +616     
================================================
+ Hits          12050      12271       +221     
- Misses         7890       8255       +365     
- Partials       1164       1194        +30     

Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716 lance6716 merged commit 336a642 into pingcap:master Jul 17, 2020
@lance6716 lance6716 deleted the reduce-ci-fail-2 branch July 17, 2020 09:33
@ti-srebot
Copy link

cherry pick to release-1.0 in PR #809

@ti-srebot ti-srebot added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Jul 17, 2020
@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jul 17, 2020
@lance6716 lance6716 mentioned this pull request Jul 24, 2020
28 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants