Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Lightning import error handling #13823

Merged
merged 10 commits into from
Apr 28, 2023
Merged

Update Lightning import error handling #13823

merged 10 commits into from
Apr 28, 2023

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Apr 27, 2023 •
edited
Loading

What is changed, added or deleted? (Required)

Update the suggested handling method for the data inaccuracy error

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.6 labels Apr 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 27, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@lilin90 lilin90 requested a review from ran-huang April 27, 2023 03:51
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 27, 2023
@lilin90 @ran-huang
Update wording
4de5614 
Co-authored-by: Ran <[email protected]>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 27, 2023
@lilin90
Copy link
Member Author

lilin90 commented Apr 27, 2023

@Frank945946 PTAL

@lilin90 lilin90 self-assigned this Apr 27, 2023
@lilin90 lilin90 mentioned this pull request Apr 27, 2023
Merged
15 tasks
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 27, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 28, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 9151881

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4384e2e into pingcap:master Apr 28, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 28, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #13832.

@lilin90 lilin90 deleted the lightning-handle-error branch April 28, 2023 03:21
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 28, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #13833.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 28, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #13834.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 28, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #13835.

This was referenced Apr 28, 2023
Merged
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Apr 28, 2023
@ti-chi-bot
Update Lightning import error handling (#13823) (#13834)
0d50a0d
ti-chi-bot bot pushed a commit that referenced this pull request Apr 28, 2023
@ti-chi-bot
Update Lightning import error handling (#13823) (#13833)
79ded61
ti-chi-bot bot pushed a commit that referenced this pull request Apr 28, 2023
@ti-chi-bot
Update Lightning import error handling (#13823) (#13832)
f883d8c
ti-chi-bot bot pushed a commit that referenced this pull request Apr 28, 2023
@ti-chi-bot
Update Lightning import error handling (#13823) (#13835)
b5ab5fa
@lilin90 lilin90 added needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Apr 28, 2023
This was referenced Apr 28, 2023
Merged
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #13836.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 28, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #13837.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 28, 2023
@ti-chi-bot
Update Lightning import error handling (#13823) (#13836)
9b78af2
ti-chi-bot bot pushed a commit that referenced this pull request Apr 28, 2023
@ti-chi-bot
Update Lightning import error handling (#13823) (#13837)
e771624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frank945946 Frank945946 Frank945946 approved these changes

@ran-huang ran-huang ran-huang approved these changes

Assignees

@lilin90 lilin90

Labels
needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilin90 @ti-chi-bot @ran-huang @Frank945946