-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Lightning import error handling #13376
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@Frank945946 @ran-huang PTAL. Thanks! |
Co-authored-by: Frank945946 <[email protected]>
/verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5ec8ac5
|
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
### What is changed, added or deleted? (Required) - Expand `JOB_TYPE` documentation for `ADMIN SHOW DDL...` output. - Add note about `temp-dir` to `tidb_enabe_fast_regorg` docs. ### Which TiDB version(s) do your changes apply to? (Required) <!-- Fill in "x" in [] to tick the checkbox below.--> **Tips for choosing the affected version(s):** By default, **CHOOSE MASTER ONLY** so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, **CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER**. For details, see [tips for choosing the affected versions](https://github.com/pingcap/docs/blob/master/CONTRIBUTING.md#guideline-for-choosing-the-affected-versions). - [x] master (the latest development version) - [x] v7.1 (TiDB 7.1 versions) - [ ] v7.0 (TiDB 7.0 versions) - [ ] v6.6 (TiDB 6.6 versions) - [x] v6.5 (TiDB 6.5 versions) - [ ] v6.1 (TiDB 6.1 versions) - [ ] v5.4 (TiDB 5.4 versions) - [ ] v5.3 (TiDB 5.3 versions) - [ ] v5.2 (TiDB 5.2 versions) - [ ] v5.1 (TiDB 5.1 versions) - [ ] v5.0 (TiDB 5.0 versions) ### What is the related PR or file link(s)? <!--Reference link(s) will help reviewers review your PR quickly.--> - This PR is translated from: - Other reference link(s): ### Do your changes match any of the following descriptions? - [ ] Delete files - [ ] Change aliases - [ ] Need modification after applied to another branch <!-- If yes, please comment "/label version-specific-changes-required" below to trigger the bot to add the label. --> - [ ] Might cause conflicts after applied to another branch
…anged, added or deleted? (Required) - Expand `JOB_TYPE` documentation for `ADMIN SHOW DDL...` output. - Add note about `temp-dir` to `tidb_enabe_fast_regorg` docs. ### Which TiDB version(s) do your changes apply to? (Required) <!-- Fill in "x" in [] to tick the checkbox below.--> **Tips for choosing the affected version(s):** By default, **CHOOSE MASTER ONLY** so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, **CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER**. For details, see [tips for choosing the affected versions](https://github.com/pingcap/docs/blob/master/CONTRIBUTING.md#guideline-for-choosing-the-affected-versions). - [x] master (the latest development version) - [x] v7.1 (TiDB 7.1 versions) - [ ] v7.0 (TiDB 7.0 versions) - [ ] v6.6 (TiDB 6.6 versions) - [x] v6.5 (TiDB 6.5 versions) - [ ] v6.1 (TiDB 6.1 versions) - [ ] v5.4 (TiDB 5.4 versions) - [ ] v5.3 (TiDB 5.3 versions) - [ ] v5.2 (TiDB 5.2 versions) - [ ] v5.1 (TiDB 5.1 versions) - [ ] v5.0 (TiDB 5.0 versions) ### What is the related PR or file link(s)? <!--Reference link(s) will help reviewers review your PR quickly.--> - This PR is translated from: - Other reference link(s): ### Do your changes match any of the following descriptions? - [ ] Delete files - [ ] Change aliases - [ ] Need modification after applied to another branch <!-- If yes, please comment "/label version-specific-changes-required" below to trigger the bot to add the label. --> - [ ] Might cause conflicts after applied to another branch
What is changed, added or deleted? (Required)
Update the suggested handling method for the data inaccuracy error
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?