Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand JOB_TYPE documentation for ADMIN SHOW DDL... output #14461

Merged
merged 6 commits into from
Jul 12, 2023

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Jul 10, 2023

What is changed, added or deleted? (Required)

  • Expand JOB_TYPE documentation for ADMIN SHOW DDL... output.
  • Add note about temp-dir to tidb_enabe_fast_reorg docs.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. translation/from-docs This PR is translated from a PR in pingcap/docs. labels Jul 10, 2023
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 10, 2023
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
@ran-huang ran-huang added the lgtm label Jul 11, 2023
@qiancai qiancai changed the title Update Lightning import error handling (#13376) Expand JOB_TYPE documentation for ADMIN SHOW DDL... output Jul 12, 2023
system-variables.md Outdated Show resolved Hide resolved
@qiancai
Copy link
Collaborator Author

qiancai commented Jul 12, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 12, 2023
@ti-chi-bot ti-chi-bot bot merged commit 40411b1 into pingcap:master Jul 12, 2023
4 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #14484.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #14485.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 12, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #14486.

qqqdan added a commit to qqqdan/docs-cn that referenced this pull request Jul 13, 2023
commit 40411b1
Author: Grace Cai <[email protected]>
Date:   Wed Jul 12 13:38:12 2023 +0800

    Expand JOB_TYPE documentation for ADMIN SHOW DDL... output (pingcap#14461)

commit 28bb83f
Author: Aolin <[email protected]>
Date:   Wed Jul 12 12:21:43 2023 +0800

    release: add v6.1.7 release notes (pingcap#14404)

commit 6074b81
Author: Grace Cai <[email protected]>
Date:   Wed Jul 12 10:45:42 2023 +0800

    system-variables: fix a typo for "GROUP" (pingcap#14471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants