Expand JOB_TYPE documentation for ADMIN SHOW DDL... output #13395

dveeden · 2023-05-01T07:18:08Z

What is changed, added or deleted? (Required)

Expand JOB_TYPE documentation for ADMIN SHOW DDL... output.
Add note about temp-dir to tidb_enabe_fast_reorg docs.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

### What is changed, added or deleted? (Required) - Expand `JOB_TYPE` documentation for `ADMIN SHOW DDL...` output. - Add note about `temp-dir` to `tidb_enabe_fast_regorg` docs. ### Which TiDB version(s) do your changes apply to? (Required)  **Tips for choosing the affected version(s):** By default, **CHOOSE MASTER ONLY** so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, **CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER**. For details, see [tips for choosing the affected versions](https://github.com/pingcap/docs/blob/master/CONTRIBUTING.md#guideline-for-choosing-the-affected-versions). - [x] master (the latest development version) - [x] v7.1 (TiDB 7.1 versions) - [ ] v7.0 (TiDB 7.0 versions) - [ ] v6.6 (TiDB 6.6 versions) - [x] v6.5 (TiDB 6.5 versions) - [ ] v6.1 (TiDB 6.1 versions) - [ ] v5.4 (TiDB 5.4 versions) - [ ] v5.3 (TiDB 5.3 versions) - [ ] v5.2 (TiDB 5.2 versions) - [ ] v5.1 (TiDB 5.1 versions) - [ ] v5.0 (TiDB 5.0 versions) ### What is the related PR or file link(s)?  - This PR is translated from: - Other reference link(s): ### Do your changes match any of the following descriptions? - [ ] Delete files - [ ] Change aliases - [ ] Need modification after applied to another branch  - [ ] Might cause conflicts after applied to another branch

ti-chi-bot · 2023-05-01T07:18:10Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

ran-huang
tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

dveeden · 2023-05-01T07:23:35Z

Some very useful comments in the code:
https://github.com/pingcap/tidb/blob/275696aa449bd7bff5c85ba3f8013d162dc690a4/parser/model/reorg.go#L37-L54

system-variables.md

Co-authored-by: Grace Cai <[email protected]>

sql-statements/sql-statement-admin-show-ddl.md

Co-authored-by: Ran <[email protected]>

dveeden · 2023-05-21T20:58:24Z

@ran-huang @qiancai PTAL

ran-huang

LGTM

system-variables.md

qiancai

/lgtm

qiancai · 2023-06-09T01:49:44Z

/verify

ran-huang · 2023-06-09T01:51:25Z

/lgtm

ti-chi-bot · 2023-06-09T01:51:30Z

[LGTM Timeline notifier]

Timeline:

2023-06-09 01:49:21.071213128 +0000 UTC m=+49375.319134946: ☑️ agreed by qiancai.
2023-06-09 01:51:29.388553108 +0000 UTC m=+49503.636474929: ☑️ agreed by ran-huang.

qiancai · 2023-06-09T01:53:13Z

/approve

ti-chi-bot · 2023-06-09T01:53:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [qiancai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-06-09T01:55:27Z

In response to a cherrypick label: new pull request created to branch release-6.5: #13820.

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2023-06-09T01:56:07Z

In response to a cherrypick label: new pull request created to branch release-7.1: #13821.

ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 1, 2023

dveeden requested review from tangenta, ran-huang and qiancai May 1, 2023 07:24

dveeden added the area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. label May 1, 2023

Update wording

264d382

tangenta approved these changes May 4, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 4, 2023

qiancai reviewed May 4, 2023

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

qiancai reviewed May 4, 2023

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

qiancai added translation/doing This PR's assignee is translating this PR. area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. labels May 4, 2023

ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label May 4, 2023

qiancai added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.0 needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed needs-cherry-pick-release-7.0 labels May 4, 2023

dveeden and others added 2 commits May 4, 2023 10:37

Update system-variables.md

cdf0a82

Co-authored-by: Grace Cai <[email protected]>

Update system-variables.md

c828b72

Co-authored-by: Grace Cai <[email protected]>

ran-huang reviewed May 5, 2023

View reviewed changes

sql-statements/sql-statement-admin-show-ddl.md Outdated Show resolved Hide resolved

Update sql-statements/sql-statement-admin-show-ddl.md

4c2799c

Co-authored-by: Ran <[email protected]>

ran-huang approved these changes May 22, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 22, 2023

ran-huang reviewed May 22, 2023

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

Update based on review

2d19975

ran-huang requested a review from qiancai June 1, 2023 04:14

qiancai reviewed Jun 9, 2023

View reviewed changes

system-variables.md Show resolved Hide resolved

swap notes based on review

5dd4183

qiancai approved these changes Jun 9, 2023

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 9, 2023

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 9, 2023

ti-chi-bot bot added the approved label Jun 9, 2023

qiancai self-assigned this Jun 9, 2023

ti-chi-bot bot merged commit 1048813 into pingcap:master Jun 9, 2023

ti-chi-bot mentioned this pull request Jun 9, 2023

Update Lightning import error handling (#13376) (#13395) #13820

Merged

15 tasks

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 9, 2023

This is an automated cherry-pick of pingcap#13395

3a1d89f

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Jun 9, 2023

Update Lightning import error handling (#13376) (#13395) #13821

Merged

15 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Jun 15, 2023

Update Lightning import error handling (#13376) (#13395) (#13821)

1195ba6

ti-chi-bot bot pushed a commit that referenced this pull request Jun 15, 2023

Update Lightning import error handling (#13376) (#13395) (#13820)

3d7cfa7

qiancai mentioned this pull request Jul 10, 2023

Expand JOB_TYPE documentation for ADMIN SHOW DDL... output pingcap/docs-cn#14461

Merged

14 tasks

qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 10, 2023

qiancai changed the title ~~Update Lightning import error handling (#13376)~~ Expand JOB_TYPE documentation for ADMIN SHOW DDL... output Jul 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expand JOB_TYPE documentation for ADMIN SHOW DDL... output #13395

Expand JOB_TYPE documentation for ADMIN SHOW DDL... output #13395

dveeden commented May 1, 2023 •

edited

Loading

ti-chi-bot bot commented May 1, 2023 •

edited

Loading

dveeden commented May 1, 2023

dveeden commented May 21, 2023

ran-huang left a comment

qiancai left a comment

qiancai commented Jun 9, 2023

ran-huang commented Jun 9, 2023

ti-chi-bot bot commented Jun 9, 2023

qiancai commented Jun 9, 2023

ti-chi-bot bot commented Jun 9, 2023

ti-chi-bot commented Jun 9, 2023

ti-chi-bot commented Jun 9, 2023

Expand JOB_TYPE documentation for ADMIN SHOW DDL... output #13395

Expand JOB_TYPE documentation for ADMIN SHOW DDL... output #13395

Conversation

dveeden commented May 1, 2023 • edited Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

ti-chi-bot bot commented May 1, 2023 • edited Loading

dveeden commented May 1, 2023

dveeden commented May 21, 2023

ran-huang left a comment

Choose a reason for hiding this comment

qiancai left a comment

Choose a reason for hiding this comment

qiancai commented Jun 9, 2023

ran-huang commented Jun 9, 2023

ti-chi-bot bot commented Jun 9, 2023

[LGTM Timeline notifier]

qiancai commented Jun 9, 2023

ti-chi-bot bot commented Jun 9, 2023

ti-chi-bot commented Jun 9, 2023

ti-chi-bot commented Jun 9, 2023

dveeden commented May 1, 2023 •

edited

Loading

ti-chi-bot bot commented May 1, 2023 •

edited

Loading