-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TiFlash: Add TiFlash edit-config instruction after manually scaled in TiFlash nodes #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birdstorm
added
translation/welcome
Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository.
needs-cherry-pick-4.0
labels
Jun 1, 2020
JaySon-Huang
reviewed
Jun 1, 2020
JaySon-Huang
approved these changes
Jun 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yikeke
reviewed
Jun 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a suggestion, Rest LGTM
yikeke
added
translation/doing
This PR’s assignee is translating this PR.
and removed
translation/welcome
Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository.
labels
Jun 1, 2020
Co-authored-by: JaySon <[email protected]>
sre-bot
pushed a commit
to sre-bot/docs-cn
that referenced
this pull request
Jun 3, 2020
Signed-off-by: sre-bot <[email protected]>
Merged
5 tasks
cherry pick to release-4.0 in PR #3469 |
yikeke
pushed a commit
that referenced
this pull request
Jun 3, 2020
Signed-off-by: sre-bot <[email protected]> Co-authored-by: birdstorm <[email protected]>
yikeke
pushed a commit
to yikeke/docs
that referenced
this pull request
Jun 5, 2020
5 tasks
yikeke
added
translation/done
This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
and removed
translation/doing
This PR’s assignee is translating this PR.
labels
Jun 5, 2020
sre-bot
added a commit
to pingcap/docs
that referenced
this pull request
Jun 8, 2020
* translate pingcap/docs-cn#3208 * translate pingcap/docs-cn#3341 * translate pingcap/docs-cn#3431 * remove taking node down section in tiflash/maintain-tiflash.md * Apply suggestions from code review Co-authored-by: Lilian Lee <[email protected]> Co-authored-by: Lilian Lee <[email protected]> Co-authored-by: pingcap-github-bot <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
translation/done
This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Add TiFlash edit-config instruction after manually scaled in TiFlash nodes
Which TiDB version(s) do your changes apply to? (Required)