Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interactive_timeout variable #4172

Merged
merged 3 commits into from
Aug 7, 2020
Merged

Add interactive_timeout variable #4172

merged 3 commits into from
Aug 7, 2020

Conversation

glkappe
Copy link
Contributor

@glkappe glkappe commented Aug 3, 2020

pingcap/tidb#8573
此变量在 3.0 release not 中已被提及,辛苦技术审核,帮忙添加此系统变量相关描述。

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@TomShawn TomShawn requested review from lysu and TomShawn August 3, 2020 11:56
@TomShawn TomShawn self-assigned this Aug 3, 2020
@TomShawn TomShawn added needs-cherry-pick-3.1 size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Aug 3, 2020
@TomShawn
Copy link
Contributor

TomShawn commented Aug 3, 2020

@lysu 请帮忙添加该变量的详细信息,谢谢!

@TomShawn TomShawn changed the title 增加 interactive_timeout 描述 Add interactive_timeout variable Aug 3, 2020
system-variables.md Outdated Show resolved Hide resolved
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 7, 2020
@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Aug 7, 2020
@ti-srebot
Copy link
Contributor

@TomShawn Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 1.

@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Aug 7, 2020
@TomShawn TomShawn merged commit 7abd45b into pingcap:master Aug 7, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 7, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #4218

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 7, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #4219

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 7, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4220

TomShawn pushed a commit that referenced this pull request Aug 7, 2020
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: glkappe <[email protected]>
ti-srebot added a commit that referenced this pull request Aug 7, 2020
* cherry pick #4172 to release-3.0

Signed-off-by: ti-srebot <[email protected]>

* Update system-variables.md

Co-authored-by: glkappe <[email protected]>
Co-authored-by: TomShawn <[email protected]>
ti-srebot added a commit that referenced this pull request Aug 7, 2020
* cherry pick #4172 to release-3.1

Signed-off-by: ti-srebot <[email protected]>

* Update system-variables.md

Co-authored-by: glkappe <[email protected]>
Co-authored-by: TomShawn <[email protected]>
@TomShawn TomShawn assigned Joyinqin and unassigned TomShawn Aug 11, 2020
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 17, 2020
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants