Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system-variables: add variable description #3672

Merged
merged 2 commits into from
Aug 17, 2020
Merged

system-variables: add variable description #3672

merged 2 commits into from
Aug 17, 2020

Conversation

Joyinqin
Copy link
Contributor

What is changed, added or deleted? (Required)

update description of the added variable.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, size/small, translation/from-docs-cn

@ti-srebot ti-srebot added needs-cherry-pick-3.0 size/small Changes of a small size. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Aug 17, 2020
@Joyinqin
Copy link
Contributor Author

/cc TomShawn, glkappe

@Joyinqin Joyinqin changed the title system-variables: Add variable description system-variables: add variable description Aug 17, 2020
@TomShawn TomShawn requested a review from lysu August 17, 2020 05:23
lysu
lysu reviewed Aug 17, 2020
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2020
@TomShawn
Copy link
Contributor

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 17, 2020
@TomShawn TomShawn merged commit ffaf67f into pingcap:master Aug 17, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 17, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#3672 to release-3.0
97fb24f 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Aug 17, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #3675

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 17, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#3672 to release-3.1
75002b8 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Aug 17, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #3676

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 17, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#3672 to release-4.0
039683f 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Aug 17, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3677

TomShawn pushed a commit that referenced this pull request Aug 17, 2020
@ti-srebot @Joyinqin
cherry pick #3672 to release-4.0 (#3677)
a7e6bbb 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: JoyinQ <[email protected]>
@Joyinqin Joyinqin deleted the variable branch August 17, 2020 14:00
ti-srebot added a commit that referenced this pull request Aug 18, 2020
@ti-srebot
system-variables: add variable description (#3672) (#3676)
aefb011 
Signed-off-by: ti-srebot <[email protected]>
ti-srebot added a commit that referenced this pull request Aug 18, 2020
@ti-srebot
system-variables: add variable description (#3672) (#3675)
3ea3025 
Signed-off-by: ti-srebot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@glkappe glkappe Awaiting requested review from glkappe

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees
No one assigned
Labels
size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Joyinqin @TomShawn @ti-srebot @lysu