Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update garbage collection docs #5856

Merged
merged 29 commits into from
Mar 29, 2021
Merged

Update garbage collection docs #5856

merged 29 commits into from
Mar 29, 2021

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Mar 26, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

This updates the docs for pingcap/tidb#21988 (now merged).

21988 still allows the previous methods for updating, but because these changes are not validated, they should not be recommended. Incorrect configuration can lead to strange behaviors.

Partially address #4549 (for backup page mentioned, there are still other pages that need readability improvements)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 26, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Mar 26, 2021 •
edited
Loading

/translation from-docs
/label v5.0
/label needs-cherry-pick-5.0

@ti-chi-bot ti-chi-bot added the v5.0 This PR/issue applies to TiDB v5.0 label Mar 26, 2021
@ti-chi-bot
Copy link
Member

@qiancai: The label(s) translation/from-docs-cn cannot be applied, because the repository doesn't have them.

In response to this:

/translation from-docs-cn
/label v5.0
/label needs-cherry-pick-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@qiancai: The label(s) translation/from-docs-cn cannot be applied, because the repository doesn't have them.

In response to this:

/translation from-docs-cn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

1 similar comment
@ti-chi-bot
Copy link
Member

@qiancai: The label(s) translation/from-docs-cn cannot be applied, because the repository doesn't have them.

In response to this:

/translation from-docs-cn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qiancai
Copy link
Collaborator Author

qiancai commented Mar 26, 2021

/translation from-docs

@ti-chi-bot ti-chi-bot added translation/from-docs This PR is translated from a PR in pingcap/docs. and removed missing-translation-status This PR does not have translation status info. labels Mar 26, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Mar 26, 2021

/cc @MyonKeminta @youjiali1995 @yikeke

@qiancai
Copy link
Collaborator Author

qiancai commented Mar 26, 2021

/status PTAL

@ti-chi-bot ti-chi-bot added the status/PTAL This PR is ready for reviewing. label Mar 26, 2021
@MyonKeminta
Copy link
Contributor

/cc @3pointer
This PR contains much modification to br's documents.

MyonKeminta
MyonKeminta reviewed Mar 26, 2021
View reviewed changes
faq/sql-faq.md Outdated Show resolved Hide resolved
MyonKeminta
MyonKeminta reviewed Mar 26, 2021
View reviewed changes
faq/sql-faq.md Outdated Show resolved Hide resolved
MyonKeminta
MyonKeminta reviewed Mar 26, 2021
View reviewed changes
garbage-collection-overview.md Outdated Show resolved Hide resolved
garbage-collection-overview.md Outdated Show resolved Hide resolved
read-historical-data.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-flashback-table.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
tidb-troubleshooting-map.md Outdated Show resolved Hide resolved
MyonKeminta
MyonKeminta reviewed Mar 29, 2021
View reviewed changes
alert-rules.md Outdated Show resolved Hide resolved
MyonKeminta
MyonKeminta approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@MyonKeminta MyonKeminta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@MyonKeminta: /lgtm is only allowed for the reviewers in list.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@yikeke
Copy link
Contributor

yikeke commented Mar 29, 2021

Please keep the English version in sync with the Chinese version If there is any modification in this PR. @qiancai

@ti-srebot ti-srebot mentioned this pull request Mar 29, 2021
Merged
11 tasks
@qiancai
Copy link
Collaborator Author

qiancai commented Mar 29, 2021

Please keep the English version in sync with the Chinese version If there is any modification in this PR. @qiancai

Yes，the changes are synchronized in pingcap/docs#5136.

@ran-huang
Copy link
Contributor

/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 29, 2021
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8cec584

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2021
@ti-chi-bot ti-chi-bot merged commit c07d248 into pingcap:master Mar 29, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 29, 2021
@qiancai @ti-srebot
cherry pick pingcap#5856 to release-5.0
11a6b2e 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5867

@qiancai qiancai mentioned this pull request Mar 29, 2021
Merged
11 tasks
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2021
Merged
11 tasks
ti-chi-bot pushed a commit that referenced this pull request Mar 29, 2021
@ti-srebot
Update garbage collection docs #4552 (#5856) (#5867)
1702a65
@yikeke yikeke changed the title Update garbage collection docs #4552 Update garbage collection docs Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer left review comments

@ran-huang ran-huang ran-huang approved these changes

@MyonKeminta MyonKeminta MyonKeminta approved these changes

@youjiali1995 youjiali1995 Awaiting requested review from youjiali1995

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs This PR is translated from a PR in pingcap/docs. v5.0 This PR/issue applies to TiDB v5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@qiancai @ti-chi-bot @MyonKeminta @ran-huang @yikeke @ti-srebot @3pointer