-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update garbage collection docs #4552
Conversation
23506ce
to
3b87cac
Compare
|
Can you keep the document for the old configuration way, but mark it to be unrecommended? |
The old method does not validate the settings, so I think it should be discouraged. There is a note on
I can change it to use a |
My understanding is that the TiDB 5.0-rc branch is for the RC only, and 5.0 GA will be based on master. So yes, it will be in v5.0. I am not sure of the docs plan fo banching, since there is now a v5.0 branch. I am not sure how docs plans to handle this though.
Done. |
/unlabel status/DNM |
@MyonKeminta, @youjiali1995, PTAL. |
@MyonKeminta, @youjiali1995, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The modification to the document includes how to prevent GC to use tools safely. But I'm afraid currently those tools will block GC by setting service safepoints automatically, and the manual operations are only needed for old versions, where the variable syntax for GC configurations is not supported. @3pointer @kennytm PTAL, thanks
/unlabel status/require-change |
hi @overvenus if you agree with the tool part of this PR, can you leave a comment "/lgtm" to enable the bot to merge? |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 98f36fc
|
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.0 in PR #5055 |
/remove-translation doing |
/translation done |
First-time contributors' checklist
What is changed, added or deleted? (Required)
This updates the docs for pingcap/tidb#21988 (now merged).
21988 still allows the previous methods for updating, but because these changes are not validated, they should not be recommended. Incorrect configuration can lead to strange behaviors.
Partially address #4549 (for backup page mentioned, there are still other pages that need readability improvements)
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?