Update description on rule based index selection #6815

xuyifangreeneyes · 2021-08-05T12:11:20Z

What is changed, added or deleted? (Required)

Update description on rule based index selection.

Closed pingcap/tidb#27230

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

This PR is translated from: None
Other reference link(s): Tracking issue for heuristic rules enhancement for index selection tidb#26020

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2021-08-05T12:11:21Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

qiancai

@xuyifangreeneyes PTAL

choose-index.md

Co-authored-by: Grace Cai <[email protected]>

xuyifangreeneyes · 2021-08-10T09:57:30Z

choose-index.md

 - 索引的列涵盖了多少访问条件。“访问条件”指的是可以转化为某列范围的 `where` 条件，如果某个索引的列集合涵盖的访问条件越多，那么它在这个维度上更优。

-对于这三种维度，如果某个索引 `idx_a` 在**三个维度上都不比 `idx_b` 差**，且**有一个维度比 `idx_b` 好**，那么就会优先选择 `idx_a`。
+- 选择该索引读表时，是否需要回表（即该索引生成的计划是 IndexReader 还是 IndexLookupReader）。不用回表的索引在这个维度上优于需要回表的索引。如果均需要回表，则比较索引的列涵盖了多少过滤条件。过滤条件指的是可以根据索引判断的 `where` 条件。如果某个索引的列集合涵盖的访问条件越多，则回表数量越少，那么它在这个维度上越优。


“访问条件”的双引号需要去掉吗

winoros

We add two examples for the warning message output.
rest LGTM

TomShawn · 2021-08-10T11:35:20Z

We add two examples for the warning message output.
rest LGTM

So what changes should be made to this doc PR?

…angreeneyes/docs-cn into rule-based-index-selection

xuyifangreeneyes · 2021-08-10T12:03:04Z

We add two examples for the warning message output.
rest LGTM

So what changes should be made to this doc PR?

I have added the two examples in this PR, please take a look.

ti-chi-bot · 2021-08-12T02:48:49Z

@winoros: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

qiancai · 2021-08-12T03:00:29Z

@Rick-lee01 PTAL

Co-authored-by: TomShawn <[email protected]>

TomShawn

LGTM

TomShawn · 2021-08-12T04:18:44Z

/merge

ti-chi-bot · 2021-08-12T04:18:46Z

@TomShawn: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn · 2021-08-12T04:18:56Z

/remove-status LGT1
/status LGT2

TomShawn · 2021-08-12T04:19:01Z

/merge

ti-chi-bot · 2021-08-12T04:19:04Z

This pull request has been accepted and is ready to merge.

Commit hash: 4613bdb

choose-index.md

add rule based index selection to doc

62f57cd

ti-chi-bot requested a review from TomShawn August 5, 2021 12:11

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 5, 2021

TomShawn added v5.2 This PR/issue applies to TiDB v5.2. translation/doing This PR’s assignee is translating this PR. labels Aug 6, 2021

ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Aug 6, 2021

TomShawn assigned Liuxiaozhen12 Aug 6, 2021

TomShawn requested a review from winoros August 6, 2021 02:22

TomShawn closed this Aug 9, 2021

TomShawn reopened this Aug 9, 2021

TomShawn added the status/PTAL This PR is ready for reviewing. label Aug 9, 2021

qiancai reviewed Aug 10, 2021

View reviewed changes

choose-index.md Outdated Show resolved Hide resolved

choose-index.md Outdated Show resolved Hide resolved

choose-index.md Outdated Show resolved Hide resolved

choose-index.md Outdated Show resolved Hide resolved

xuyifangreeneyes and others added 3 commits August 10, 2021 17:51

Update choose-index.md

169160e

Co-authored-by: Grace Cai <[email protected]>

Apply suggestions from code review

eef6091

Co-authored-by: Grace Cai <[email protected]>

Update choose-index.md

4d5794d

Co-authored-by: Grace Cai <[email protected]>

xuyifangreeneyes commented Aug 10, 2021

View reviewed changes

winoros reviewed Aug 10, 2021

View reviewed changes

xuyifangreeneyes added 2 commits August 10, 2021 20:01

add two examples

3052f88

Merge branch 'rule-based-index-selection' of https://github.com/xuyif…

1400a9e

…angreeneyes/docs-cn into rule-based-index-selection

ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2021

xuyifangreeneyes requested review from winoros and qiancai August 10, 2021 12:03

winoros approved these changes Aug 12, 2021

View reviewed changes

xuyifangreeneyes and others added 6 commits August 12, 2021 11:54

Update choose-index.md

4264f38

Co-authored-by: TomShawn <[email protected]>

Update choose-index.md

cdec098

Co-authored-by: TomShawn <[email protected]>

Update choose-index.md

a40f76a

Co-authored-by: TomShawn <[email protected]>

Update choose-index.md

b701967

Co-authored-by: TomShawn <[email protected]>

Update choose-index.md

b38e80b

Co-authored-by: TomShawn <[email protected]>

Update choose-index.md

bc403c4

Co-authored-by: TomShawn <[email protected]>

xuyifangreeneyes requested a review from TomShawn August 12, 2021 04:06

xuyifangreeneyes and others added 2 commits August 12, 2021 12:09

Update choose-index.md

f5979c0

Co-authored-by: TomShawn <[email protected]>

Update choose-index.md

4613bdb

Co-authored-by: TomShawn <[email protected]>

TomShawn approved these changes Aug 12, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 12, 2021

TomShawn removed the status/require-change Needs the author to address comments. label Aug 12, 2021

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 12, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 12, 2021

TomShawn reviewed Aug 12, 2021

View reviewed changes

choose-index.md Outdated Show resolved Hide resolved

trigger CI

45c365c

ti-chi-bot merged commit afe0e53 into pingcap:master Aug 12, 2021

Liuxiaozhen12 mentioned this pull request Aug 13, 2021

Update description on rule based index selection pingcap/docs#6160

Merged

12 tasks

Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 13, 2021

xuyifangreeneyes mentioned this pull request Aug 14, 2021

Tracking issue for heuristic rules enhancement for index selection pingcap/tidb#26020

Closed

8 tasks

xuyifangreeneyes mentioned this pull request Aug 26, 2021

tiny fix on index selection #6979

Merged

12 tasks

ti-chi-bot mentioned this pull request Aug 26, 2021

tiny fix on index selection (#6979) #6984

Merged

12 tasks

xuyifangreeneyes deleted the rule-based-index-selection branch October 30, 2021 05:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update description on rule based index selection #6815

Update description on rule based index selection #6815

xuyifangreeneyes commented Aug 5, 2021 •

edited by tisonkun

Loading

ti-chi-bot commented Aug 5, 2021 •

edited

Loading

qiancai left a comment

xuyifangreeneyes Aug 10, 2021

winoros left a comment

TomShawn commented Aug 10, 2021

xuyifangreeneyes commented Aug 10, 2021

ti-chi-bot commented Aug 12, 2021

qiancai commented Aug 12, 2021

TomShawn left a comment

TomShawn commented Aug 12, 2021

ti-chi-bot commented Aug 12, 2021

TomShawn commented Aug 12, 2021

TomShawn commented Aug 12, 2021

ti-chi-bot commented Aug 12, 2021

Update description on rule based index selection #6815

Update description on rule based index selection #6815

Conversation

xuyifangreeneyes commented Aug 5, 2021 • edited by tisonkun Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

ti-chi-bot commented Aug 5, 2021 • edited Loading

qiancai left a comment

Choose a reason for hiding this comment

xuyifangreeneyes Aug 10, 2021

Choose a reason for hiding this comment

winoros left a comment

Choose a reason for hiding this comment

TomShawn commented Aug 10, 2021

xuyifangreeneyes commented Aug 10, 2021

ti-chi-bot commented Aug 12, 2021

qiancai commented Aug 12, 2021

TomShawn left a comment

Choose a reason for hiding this comment

TomShawn commented Aug 12, 2021

ti-chi-bot commented Aug 12, 2021

TomShawn commented Aug 12, 2021

TomShawn commented Aug 12, 2021

ti-chi-bot commented Aug 12, 2021

xuyifangreeneyes commented Aug 5, 2021 •

edited by tisonkun

Loading

ti-chi-bot commented Aug 5, 2021 •

edited

Loading