Tracking issue for heuristic rules enhancement for index selection

[winoros]

Enhancement

This issue tracks the status of the heuristic rules used for index selection to pruning some indexes by rule. This can help TiDB avoid choosing some wrong indexes by the out-date/not-good statistics.

• Create proposal of heuristic rules enhancement for index selection #27227
• Adding new heuristic rules #26319
• Refine the skyline pruning #26320
• refine prefer-range-scan behavior #27228
• Functional tests of heuristic rules enhancement for index selection #27229
• Scenario tests if needed (No need)
• Documentation of heuristic rules enhancement for index selection #27230

Follow ups:

• Skyline pruning prunes maybe-good prefix index #27313

[tisonkun]

Hello @winoros ! We published a planning for TiDB v5.2 development cycle. Is this feature to be included? If so, would you mind to comment on the thread so that the author can update information?

[xuyifangreeneyes]

/sig planner

[tisonkun]

@xuyifangreeneyes @winoros do we briefly describe todo items or draft a proposal? What heuristic rules we'd like to implement? Is there a framework already or we will introduce a framework at first.

[xuyifangreeneyes]

@xuyifangreeneyes @winoros do we briefly describe todo items or draft a proposal? What heuristic rules we'd like to implement? Is there a framework already or we will introduce a framework at first.

Here is a design doc.

[tisonkun]

@xuyifangreeneyes can we make a proposal follow design doc process?

[tisonkun]

Also this document is private that cannot be accessed.

[xuyifangreeneyes]

Also this document is private that cannot be accessed.

sorry, check the link: https://docs.google.com/document/d/1pzm6LV7jbPK2oPCMFe-iEUXu7Jf7R5cvaSq9Lgo-a1U/edit?usp=sharing

[xuyifangreeneyes]

@xuyifangreeneyes can we make a proposal follow design doc process?

Sure, I will write one.

[tisonkun]

@xuyifangreeneyes is there any schedule to push a design document? At least I think @winoros or you can create a subtask for it now.

[xuyifangreeneyes]

@xuyifangreeneyes is there any schedule to push a design document? At least I think @winoros or you can create a subtask for it now.

@tisonkun I write a design document #27223. I doesn't have the access to modify the tracking issue. Maybe @winoros or you can update the tracking issue? The untracked PR list as following:

• Design doc for rule based index selection: docs: add design doc for rule based index selection #27223
• Add test for always-good heuristics: planner: add test for heuristic index selection #26917
• Output skyline pruning information when executing EXPLAIN: planner: output skyline pruning information when executing EXPLAIN #26748
• Docs-cn update for rule based index selection: Update description on rule based index selection docs-cn#6815
• Refine prefer-range-scan behavior: planner: refine prefer-range-scan behavior #27123

[tisonkun]

@xuyifangreeneyes thanks for your information. Updated.

[tisonkun]

@xuyifangreeneyes please check whether we can close this issue as all tasks done.

[xuyifangreeneyes]

@xuyifangreeneyes please check whether we can close this issue as all tasks done.

There is another open pr #27527 related to skyline pruning. IMHO we can close the issue after the pr is merged.

[tisonkun]

@xuyifangreeneyes thanks! Updated the information on issue description. I do think @github should enable contributors to associate/create subtasks >_<

[tisonkun]

Closed as #27527 merged.