dm: update dm-precheck.md #8409

okJiang · 2022-02-16T14:59:18Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

update dm/dm-precheck.md

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s): dm: Tracking issue Enhanced Pre-Checker tiflow#3608, Upstream database user privileges wrong docs-dm#815

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2022-02-16T14:59:20Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

okJiang · 2022-02-16T15:02:01Z

/cc @sunzhaoyang @lance6716

dm/dm-precheck.md

sunzhaoyang · 2022-02-17T01:47:58Z

dm/dm-precheck.md


-            - 分表存在自增主键，且自增主键 column 类型不为 bigint
-            - 分表存在自增主键，自增主键 column 类型为 bigint，但没有为其配置列值转换
+ 检查上游是否处于 [Online-DDL](/dm/feature-online-ddl.md) 过程中，即创建了 `ghost` 表，但还未执行 `rename` 的阶段。


再补充下这个检查结果吧。如果上游出于 online ddl 中，将会怎样，用户应该如何做

dm/dm-precheck.md

TomShawn · 2022-02-18T07:18:11Z

@okJiang 这个文档改动是适用于 v5.4 以后的版本吗？

okJiang · 2022-02-18T07:19:03Z

@okJiang 这个文档改动是适用于 v5.4 以后的版本吗？

是的，我之前标错了

Co-authored-by: sunzy <[email protected]>

okJiang · 2022-02-18T08:44:21Z

all comment fixed. ptal again @sunzhaoyang

dm/dm-precheck.md

sunzhaoyang · 2022-02-21T07:07:48Z

dm/dm-precheck.md

+```yaml
+mydumpers:                           # dump 处理单元的运行配置参数
+  global:                            # 配置名称
+    threads: 4                       # dump 处理单元从上游数据库实例导出数据和 check-task 访问上游的线程数量，默认值为 4


Suggested change

threads: 4 # dump 处理单元从上游数据库实例导出数据和 check-task 访问上游的线程数量，默认值为 4

threads: 4 # dump 处理单元从上游数据库实例导出数据和执行前置检查时访问上游的线程数量，默认值为 4，建议不要超过 64。

这个 64 是我拍的，可能不是合理的值

之前的 dumpThread 有设置过大而产生的 issue 和 oncall 么？我们应该在文档中标明这个参数的影响就好了，例如

该参数与上游的连接数有关，如果太大可能会加大上游的负载

Co-authored-by: Ehco <[email protected]>

Ehco1996

LGTM

dm/dm-precheck.md

shichun-0415 · 2022-03-18T11:58:59Z

dm/dm-precheck.md

+
+    对于全量加增量数据迁移模式，除了通用检查项外，前置检查还将包含全量数据迁移模式（`task-mode: full`）相关的检查项，以及增量数据迁移模式（`task-mode: incremental`）相关的检查项。
+
+## 检查配置


标题不够明确，检查配置和前面检查项是什么关系？

这个是 checker 本身的配置，用于配置 checker 自己的参数的，和前面的检查项没关系

Co-authored-by: shichun-0415 <[email protected]>

dm/dm-precheck.md

shichun-0415 · 2022-03-21T02:43:42Z

dm/dm-precheck.md


-+ 数据库配置
+* 通用检查项


跟“通用检查项”并列的是什么呢？如果没有，用 item list 不太合适。

因为 CI 里要求使用统一的 code block style

dm/dm-precheck.md

Co-authored-by: shichun-0415 <[email protected]>

shichun-0415

LGTM

qiancai · 2022-03-21T08:10:44Z

/remove-status LGT1
/status LGT2

qiancai · 2022-03-21T08:11:00Z

/merge

ti-chi-bot · 2022-03-21T08:11:04Z

This pull request has been accepted and is ready to merge.

Commit hash: 45c1846

update dm-precheck.md

da13aaf

ti-chi-bot requested a review from TomShawn February 16, 2022 14:59

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 16, 2022

ti-chi-bot requested review from lance6716 and sunzhaoyang February 16, 2022 15:02

sunzhaoyang reviewed Feb 17, 2022

View reviewed changes

dm/dm-precheck.md Outdated Show resolved Hide resolved

sunzhaoyang reviewed Feb 17, 2022

View reviewed changes

dm/dm-precheck.md Outdated Show resolved Hide resolved

sunzhaoyang reviewed Feb 17, 2022

View reviewed changes

dm/dm-precheck.md Outdated Show resolved Hide resolved

sunzhaoyang reviewed Feb 17, 2022

View reviewed changes

dm/dm-precheck.md Outdated Show resolved Hide resolved

TomShawn added area/dm needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Feb 17, 2022

TomShawn requested a review from shichun-0415 February 17, 2022 02:28

TomShawn assigned shichun-0415 Feb 17, 2022

okJiang removed the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Feb 18, 2022

TomShawn added for-future-release This PR only applies to master for now and might cherry-pick to a future release. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 18, 2022

okJiang and others added 2 commits February 18, 2022 16:18

Apply suggestions from code review

33e5c3d

Co-authored-by: sunzy <[email protected]>

address comment

806bf46

okJiang mentioned this pull request Feb 21, 2022

dm: Tracking issue Enhanced Pre-Checker pingcap/tiflow#3608

Closed

11 tasks

sunzhaoyang reviewed Feb 21, 2022

View reviewed changes

dm/dm-precheck.md Outdated Show resolved Hide resolved

sunzhaoyang reviewed Feb 21, 2022

View reviewed changes

Update dm/dm-precheck.md

82991f8

Co-authored-by: Ehco <[email protected]>

Ehco1996 approved these changes Mar 14, 2022

View reviewed changes

shichun-0415 mentioned this pull request Mar 18, 2022

fix the upstream database user privileges pingcap/docs-dm#816

Closed

8 tasks

shichun-0415 reviewed Mar 18, 2022

View reviewed changes

Apply suggestions from code review

23d0fac

Co-authored-by: shichun-0415 <[email protected]>

shichun-0415 reviewed Mar 21, 2022

View reviewed changes

dm/dm-precheck.md Show resolved Hide resolved

shichun-0415 reviewed Mar 21, 2022

View reviewed changes

dm/dm-precheck.md Outdated Show resolved Hide resolved

Ehco1996 added 3 commits March 21, 2022 10:09

refine for ci

072e9f1

format with linter

dc9ad30

fix code block style

447891f

shichun-0415 reviewed Mar 21, 2022

View reviewed changes

Ehco1996 and others added 5 commits March 21, 2022 11:16

Update dm/dm-precheck.md

6f6cc0f

Co-authored-by: shichun-0415 <[email protected]>

Update dm/dm-precheck.md

626dd6d

Co-authored-by: shichun-0415 <[email protected]>

Apply suggestions from code review

c25d2a8

Co-authored-by: shichun-0415 <[email protected]>

adjusted doc structure

36f1e92

Update dm-precheck.md

45c1846

shichun-0415 approved these changes Mar 21, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 21, 2022

qiancai removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2022

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 21, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 21, 2022

ti-chi-bot merged commit 16ec173 into pingcap:master Mar 21, 2022

qiancai mentioned this pull request Mar 23, 2022

dm: update dm-precheck.md pingcap/docs#7907

Merged

16 tasks

qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 23, 2022

ti-chi-bot mentioned this pull request Apr 2, 2022

dm: update dm-precheck.md (#7907) pingcap/docs#8056

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dm: update dm-precheck.md #8409

dm: update dm-precheck.md #8409

okJiang commented Feb 16, 2022 •

edited by shichun-0415

Loading

ti-chi-bot commented Feb 16, 2022 •

edited

Loading

okJiang commented Feb 16, 2022

sunzhaoyang Feb 17, 2022

TomShawn commented Feb 18, 2022

okJiang commented Feb 18, 2022

okJiang commented Feb 18, 2022

sunzhaoyang Feb 21, 2022

sunzhaoyang Feb 21, 2022

okJiang Feb 21, 2022

Ehco1996 left a comment

shichun-0415 Mar 18, 2022

Ehco1996 Mar 19, 2022

shichun-0415 Mar 21, 2022

Ehco1996 Mar 21, 2022

shichun-0415 left a comment

qiancai commented Mar 21, 2022

qiancai commented Mar 21, 2022

ti-chi-bot commented Mar 21, 2022

	threads: 4 # dump 处理单元从上游数据库实例导出数据和 check-task 访问上游的线程数量，默认值为 4
	threads: 4 # dump 处理单元从上游数据库实例导出数据和执行前置检查时访问上游的线程数量，默认值为 4，建议不要超过 64。


		对于全量加增量数据迁移模式，除了通用检查项外，前置检查还将包含全量数据迁移模式（`task-mode: full`）相关的检查项，以及增量数据迁移模式（`task-mode: incremental`）相关的检查项。

		## 检查配置

dm: update dm-precheck.md #8409

dm: update dm-precheck.md #8409

Conversation

okJiang commented Feb 16, 2022 • edited by shichun-0415 Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

ti-chi-bot commented Feb 16, 2022 • edited Loading

okJiang commented Feb 16, 2022

Choose a reason for hiding this comment

TomShawn commented Feb 18, 2022

okJiang commented Feb 18, 2022

okJiang commented Feb 18, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ehco1996 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shichun-0415 left a comment

Choose a reason for hiding this comment

qiancai commented Mar 21, 2022

qiancai commented Mar 21, 2022

ti-chi-bot commented Mar 21, 2022

okJiang commented Feb 16, 2022 •

edited by shichun-0415

Loading

ti-chi-bot commented Feb 16, 2022 •

edited

Loading