Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: Tracking issue Enhanced Pre-Checker #3608

Closed
10 of 11 tasks
okJiang opened this issue Nov 24, 2021 · 2 comments
Closed
10 of 11 tasks

dm: Tracking issue Enhanced Pre-Checker #3608

okJiang opened this issue Nov 24, 2021 · 2 comments
Labels
subject/new-feature Denotes an issue or pull request adding a new feature. type/feature Issues about a new feature

Comments

@okJiang
Copy link
Member

okJiang commented Nov 24, 2021 •
edited
Loading

This issue is tracking Enhanced Pre-Checker.

In short, our checker make user misuse, take too much time in some situation, some under-consideration and so on. See details in RFC(dm): Add enhanced pre-check rfc.

Tracking issues:
@okJiang okJiang added the subject/new-feature Denotes an issue or pull request adding a new feature. label Nov 24, 2021
@okJiang okJiang changed the title dm: enhanced pre-checker dm: Tracking issue Enhanced Pre-Checker Dec 2, 2021
@okJiang okJiang mentioned this issue Dec 29, 2021
Merged
ti-chi-bot pushed a commit that referenced this issue Jan 12, 2022
@okJiang
checker(dm): make start-task/resume-task/check-task return pre-chec…
750816f 
…k result only warning (#4118)

ref #3608
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this issue Jan 20, 2022
@okJiang @zhaoxinyu
checker(dm): make start-task/resume-task/check-task return pre-chec…
e210926 
…k result only warning (pingcap#4118)

ref pingcap#3608
@okJiang okJiang mentioned this issue Feb 16, 2022
Merged
15 tasks
@okJiang
Copy link
Member Author

okJiang commented Feb 21, 2022 •
edited
Loading

due to optimistic table structure checker also should return warning about AUTO_INCREMENT_ID, move the AUTO_INCREMENT_ID checker from pessimistic table structure checker to a single checker

------update

If move it to a single checker, will open more goroutines and add upstream's load. So just add it in optimistic checker.

@okJiang okJiang mentioned this issue Feb 21, 2022
Merged
@lance6716 lance6716 added the type/feature Issues about a new feature label Feb 21, 2022
ti-chi-bot pushed a commit that referenced this issue Feb 24, 2022
@okJiang
checker(dm): add auto increment id check in optimistic (#4636)
089c3b2 
ref #3608
@okJiang
Copy link
Member Author

okJiang commented Mar 23, 2022

With the document complete, this issue close.

@okJiang okJiang closed this as completed Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
subject/new-feature Denotes an issue or pull request adding a new feature. type/feature Issues about a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lance6716 @okJiang