Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to new prow reviewing #2297

Merged
merged 2 commits into from
May 16, 2023
Merged

chore: migrate to new prow reviewing #2297

merged 2 commits into from
May 16, 2023

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Apr 6, 2023 •
edited by lilin90
Loading

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Add prow OWNERS files, it's a part of the implement of https://internals.tidb.io/t/topic/854.

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 6, 2023 •
edited by ti-chi-bot bot
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lilin90
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Apr 6, 2023
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 6, 2023
@wuhuizuo wuhuizuo added translation/no-need The changes in this PR don't need to be translated. and removed missing-translation-status This PR does not have translation status info. labels Apr 6, 2023
@wuhuizuo
Copy link
Contributor Author

It should be cherry-picked to release branches when merged, but no need to deploy.

@wuhuizuo
Copy link
Contributor Author

/hold wait the bot configuration be updated.

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2023
@wuhuizuo wuhuizuo marked this pull request as ready for review April 10, 2023 04:15
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2023
@wuhuizuo
Copy link
Contributor Author

/unhold it will not affect anything before the bot configuration be updated.

@wuhuizuo
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2023
@lilin90 lilin90 self-requested a review April 10, 2023 08:39
@lilin90 lilin90 mentioned this pull request May 9, 2023
Merged
12 tasks
@lilin90 lilin90 added needs-cherry-pick-release-1.2 Should cherry pick this PR to release-1.2 branch. needs-cherry-pick-release-1.3 Should cherry pick this PR to release-1.3 branch. needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. labels May 12, 2023
lilin90
lilin90 approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 16, 2023
@lilin90 lilin90 self-assigned this May 16, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 16, 2023
lilin90
lilin90 reviewed May 16, 2023
View reviewed changes
OWNERS Outdated Show resolved Hide resolved
@lilin90
Copy link
Member

lilin90 commented May 16, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 16, 2023

This pull request has been accepted and is ready to merge.

Commit hash: a643eec

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 16, 2023
@ti-chi-bot ti-chi-bot bot merged commit a534ff8 into master May 16, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2023
Merged
6 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.2: #2361.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.3: #2362.

This was referenced May 16, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.4: #2363.

@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2023
Merged
6 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.5: #2364.

@lilin90 lilin90 deleted the feature/review-config branch May 16, 2023 07:07
This was referenced May 16, 2023
Merged
Merged
Merged
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#2297) (#2364)
73c40c0
This was referenced May 16, 2023
Merged
Merged
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#2297) (#2361)
623ae42
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#2297) (#2363)
bf7b5e0
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#2297) (#2362)
f4d6c46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@ran-huang ran-huang ran-huang approved these changes

Assignees

@lilin90 lilin90

Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-release-1.2 Should cherry pick this PR to release-1.2 branch. needs-cherry-pick-release-1.3 Should cherry pick this PR to release-1.3 branch. needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need The changes in this PR don't need to be translated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wuhuizuo @ti-chi-bot @lilin90 @ran-huang