Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to new prow reviewing #13160

Merged
merged 2 commits into from
May 16, 2023
Merged

chore: migrate to new prow reviewing #13160

merged 2 commits into from
May 16, 2023

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Apr 6, 2023 •
edited by lilin90
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add prow OWNERS files, it's a part of implement of https://internals.tidb.io/t/topic/854.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 6, 2023 •
edited by ti-chi-bot bot
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lilin90
  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 6, 2023
@CLAassistant
Copy link

CLAassistant commented Apr 6, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 6, 2023
@wuhuizuo wuhuizuo added the translation/no-need No need to translate this PR. label Apr 10, 2023
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Apr 10, 2023
@wuhuizuo
Copy link
Contributor Author

/hold wait for bot configuration be updated.

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2023
@wuhuizuo wuhuizuo marked this pull request as ready for review April 10, 2023 07:50
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2023
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Apr 10, 2023 •
edited
Loading

/unhold it will not affect anything before bot configuration be updated.

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2023
@lilin90 lilin90 self-requested a review April 10, 2023 08:39
@lilin90 lilin90 added needs-cherry-pick-release-3.0 needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels May 12, 2023
lilin90
lilin90 approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 16, 2023
@lilin90 lilin90 self-assigned this May 16, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-3.0: #13572.

This was referenced May 16, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.1: #13573.

@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.2: #13574.

@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #13575.

@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #13576.

@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #13577.

@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #13578.

@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-4.0: #13579.

@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.0: #13580.

@lilin90 lilin90 deleted the feature/review-config branch May 16, 2023 07:29
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#13160) (#13578)
1986ab5
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#13160) (#13573)
5c64464
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#13160) (#13575)
a45a30d
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#13160) (#13576)
23b2d21
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#13160) (#13574)
e1bace9
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#13160) (#13577)
64bbc7d
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#13160) (#13571)
7254473
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#13160) (#13579)
adf5aed
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#13160) (#13580)
e53d6d4
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#13160) (#13572)
cadfb59
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#13160) (#13570)
5d9c93f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@lilin90 lilin90

Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wuhuizuo @ti-chi-bot @CLAassistant @lilin90 @qiancai